Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: fix offsets for TypedArray deserialization #12143

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

address review suggestion

  • Loading branch information...
addaleax committed Mar 31, 2017
commit 625b3247d3985053e9ca952ff93716ce454dccd5
@@ -121,8 +121,9 @@ const objects = [

{
// Unaligned Uint16Array read, with padding in the underlying array buffer.
const buf = Buffer.from('0'.repeat(64) + 'ff0d5c0404addeefbe', 'hex')
.slice(32);
let buf = Buffer.alloc(32 + 9);
buf.write('ff0d5c0404addeefbe', 32, 'hex');
buf = buf.slice(32);
assert.deepStrictEqual(v8.deserialize(buf),
new Uint16Array([0xdead, 0xbeef]));
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.