New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: show External values explicitly in inspect #12151

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@addaleax
Member

addaleax commented Mar 31, 2017

Display v8::External values as [External] rather than {}
which makes them look like objects.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

util

util: show External values explicitly in inspect
Display `v8::External` values as `[External]` rather than `{}`
which makes them look like objects.
@jasnell

jasnell approved these changes Apr 1, 2017

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Apr 3, 2017

Member

Landed in 3cc3e09

Member

addaleax commented Apr 3, 2017

Landed in 3cc3e09

@addaleax addaleax closed this Apr 3, 2017

@addaleax addaleax deleted the addaleax:inspect-external branch Apr 3, 2017

addaleax added a commit that referenced this pull request Apr 3, 2017

util: show External values explicitly in inspect
Display `v8::External` values as `[External]` rather than `{}`
which makes them look like objects.

PR-URL: #12151
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment