New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid passing kill empty input in Makefile #12158

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
7 participants
@gibfahn
Member

gibfahn commented Apr 1, 2017

Using xargs -r on some platforms and xargs on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

I ran into this as I'm on macOS, but have a GNU xargs (from brew install findutils).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

cc/ @Trott @nodejs/build

EDIT: CI: https://ci.nodejs.org/job/node-test-commit/8825/ - CI is green

@gibfahn gibfahn requested a review from Trott Apr 1, 2017

@Trott

Trott approved these changes Apr 1, 2017

Much better. Thanks for this. LGTM if CI is green.

@jasnell

jasnell approved these changes Apr 3, 2017

build: avoid passing kill empty input in Makefile
Using `xargs -r` on some platforms and `xargs` on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

PR-URL: #12158
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn merged commit d19809a into nodejs:master Apr 4, 2017

@gibfahn gibfahn deleted the gibfahn:xargs-makefile branch Apr 4, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017

Closed

8.0.0 Release Proposal #12220

@italoacasas

This comment has been minimized.

Show comment
Hide comment
@italoacasas
Member

italoacasas commented Apr 10, 2017

@gibfahn gibfahn restored the gibfahn:xargs-makefile branch Apr 11, 2017

@gibfahn gibfahn deleted the gibfahn:xargs-makefile branch Apr 11, 2017

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Apr 11, 2017

Member

v7.x backport: #12337

Member

gibfahn commented Apr 11, 2017

v7.x backport: #12337

gibfahn added a commit to gibfahn/node that referenced this pull request May 22, 2017

build: avoid passing kill empty input in Makefile
Using `xargs -r` on some platforms and `xargs` on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

PR-URL: nodejs#12158
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 17, 2017

Member

Should land after #11246

Member

gibfahn commented Jun 17, 2017

Should land after #11246

gibfahn added a commit that referenced this pull request Jun 18, 2017

build: avoid passing kill empty input in Makefile
Using `xargs -r` on some platforms and `xargs` on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

PR-URL: #12158
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@gibfahn gibfahn added land-on-v6.x and removed lts-watch-v6.x labels Jun 18, 2017

gibfahn added a commit that referenced this pull request Jun 20, 2017

build: avoid passing kill empty input in Makefile
Using `xargs -r` on some platforms and `xargs` on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

PR-URL: #12158
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit that referenced this pull request Jul 11, 2017

build: avoid passing kill empty input in Makefile
Using `xargs -r` on some platforms and `xargs` on others doesn't work,
we can't guarantee whether xargs is GNU or not. Avoid the issue by only
running kill if there are processes to clean.

PR-URL: #12158
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment