Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add variable arguments support for Argv #12166

Closed
wants to merge 1 commit into from

Conversation

@danbev
Copy link
Member

commented Apr 2, 2017

At the moment Argv only supports three arguments which fulfilled my
requirements when working on #9163.

This commit adds support for a variable number of arguments. There is
also a no-args constructor that is the equivalent to running "node -p
process.version" which is hopefully alright as a default.

Refs: #9163

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add variable arguments support for Argv
At the moment Argv only supports three arguments which fulfilled my
requirements when working on #9163.

This commit adds support for a variable number of arguments. There is
also a no-args constructor that is the equivalent to running "node -p
process.version" which is hopefully alright as a default.

Refs: #9163

@Trott Trott added the C++ label Apr 2, 2017

@jasnell
jasnell approved these changes Apr 3, 2017
@jasnell

This comment has been minimized.

jasnell added a commit that referenced this pull request Apr 4, 2017
test: add variable arguments support for Argv
At the moment Argv only supports three arguments which fulfilled my
requirements when working on #9163.

This commit adds support for a variable number of arguments. There is
also a no-args constructor that is the equivalent to running "node -p
process.version" which is hopefully alright as a default.

PR-URL: #12166
Ref: #9163
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

Landed in 5ccaba4

@jasnell jasnell closed this Apr 4, 2017

@jasnell jasnell referenced this pull request Apr 4, 2017

@danbev danbev deleted the danbev:varargs branch Apr 6, 2017

@italoacasas

This comment has been minimized.

Copy link
Member

commented Apr 10, 2017

cc @danbev

@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2017

@italoacasas Sorry I missed this message. Would you like me to open at PR against v7.x-staging with a backport?

@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.