Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove disabled debugger test #12199

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Apr 4, 2017

The current debugger is slated for removal soon. The debugger test that
has been disabled for over four years is unlikely to be repaired at this
point. Remove the test and its associated fixture.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test debugger

test: remove disabled debugger test
The current debugger is slated for removal soon. The debugger test that
has been disabled for over four years is unlikely to be repaired at this
point. Remove the test and its associated fixture.
@thefourtheye

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2017

Would it be better if we removed this when we do away with the current debugger?

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

@thefourtheye I'd say it's long overdue for removal. It never worked reliably and it's been disabled four out of the five years it's been around.

@gibfahn
gibfahn approved these changes Apr 4, 2017
Copy link
Member

left a comment

LGTM, I can't see a reason not to get rid of it now.

@cjihrig
cjihrig approved these changes Apr 4, 2017
@jasnell
jasnell approved these changes Apr 4, 2017
@hiroppy
hiroppy approved these changes Apr 5, 2017
@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2017

jasnell added a commit that referenced this pull request Apr 6, 2017
test: remove disabled debugger test
The current debugger is slated for removal soon. The debugger test that
has been disabled for over four years is unlikely to be repaired at this
point. Remove the test and its associated fixture.

PR-URL: #12199
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 6, 2017

Landed in 65c100a

@italoacasas

This comment has been minimized.

Copy link
Member

commented Apr 10, 2017

cc @Trott

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.