New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't test addons-napi twice #12201

Merged
merged 1 commit into from Apr 9, 2017

Conversation

@gibfahn
Member

gibfahn commented Apr 4, 2017

The addons-napi testsuite is already included in $(CI_NATIVE_SUITES), so
we don't need to manually specify it in the test-ci target as well.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

CI: https://ci.nodejs.org/job/node-test-commit/8866/ EDIT: Windows failed
CI 2: https://ci.nodejs.org/job/node-test-commit/8867/
CI 3: https://ci.nodejs.org/job/node-test-commit/8939/
CI 4: https://ci.nodejs.org/job/node-test-commit/8984/

@danbev

danbev approved these changes Apr 4, 2017

@cjihrig

cjihrig approved these changes Apr 4, 2017

@jasnell

jasnell approved these changes Apr 4, 2017

@mhdawson

LGTM

@mscdex mscdex added the test label Apr 4, 2017

build: don't test addons-napi twice
The addons-napi testsuite is already included in $(CI_NATIVE_SUITES), so
we don't need to manually specify it in the test-ci target as well.

PR-URL: #12201
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@gibfahn gibfahn merged commit 4dde876 into nodejs:master Apr 9, 2017

@gibfahn gibfahn deleted the gibfahn:n-api-makefile branch Apr 9, 2017

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment