Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check curve algorithm is supported #12265

Closed

Conversation

@Qantas94Heavy
Copy link
Member

commented Apr 7, 2017

parallel/test-crypto-dh.js assumes particular curve algorithms
(e.g. Oakley-EC2N-3) are supported, though this may not necessarily be
the case if Node.js was built with a system version of OpenSSL.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: check curve algorithm is supported
parallel/test-crypto-dh.js assumes particular curve algorithms
(e.g. Oakley-EC2N-3) are supported, though this may not necessarily be
the case if Node.js was built with a system version of OpenSSL.
@bnoordhuis
Copy link
Member

left a comment

LGTM, although I can't vouch it won't break again as we don't test this configuration in our CI matrix.

Speaking of which: https://ci.nodejs.org/job/node-test-pull-request/7262/

@mscdex mscdex added the crypto label Apr 7, 2017

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 10, 2017

Landed in 2555780, thanks for the PR!

@addaleax addaleax closed this Apr 10, 2017

addaleax added a commit that referenced this pull request Apr 10, 2017
test: check curve algorithm is supported
parallel/test-crypto-dh.js assumes particular curve algorithms
(e.g. Oakley-EC2N-3) are supported, though this may not necessarily be
the case if Node.js was built with a system version of OpenSSL.

PR-URL: #12265
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@italoacasas

This comment has been minimized.

Copy link
Member

commented Apr 10, 2017

@Qantas94Heavy Qantas94Heavy deleted the Qantas94Heavy:fix-crypto-dh-test branch Apr 29, 2017

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.