New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: drop PPC BE from supported platforms #12309

Closed
wants to merge 1 commit into
base: master
from

Conversation

@mhdawson
Member

mhdawson commented Apr 10, 2017

We've discussed this with the Power team within IBM and have
agreement that we should drop Power Linux BE for Node version
8 as customers will be using Power Linux LE when using
Node.js going forward.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc

doc: drop PPC BE from supported platforms
We've discussed this with the Power team within IBM and have
agreement that we should drop Power Linux BE for Node version
8 as customers will be using Power Linux LE when using
Node.js going forward.
@gibfahn

This comment has been minimized.

Show comment
Hide comment
Member

gibfahn commented Apr 10, 2017

@gdams

gdams approved these changes Apr 10, 2017

LGTM

refack added a commit to refack/build that referenced this pull request Apr 10, 2017

refack added a commit to refack/build that referenced this pull request Apr 10, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack
Member

refack commented Apr 10, 2017

@jbajwa

jbajwa approved these changes Apr 10, 2017

@jasnell

This LGTM but just thinking... do we need a proper deprecation cycle for dropping support for a platform? Does that even make sense?

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Apr 11, 2017

Member

@jasnell in general I think the more warning we can give people the better. This may be a bit of a special situation where Power Linux essentially switched the primary endianess and there were both options for a transition period. I suggest we land this but then discuss in the LTS team what we want the standard process to be. We should probably also do the same in terms of OS versions.

Member

mhdawson commented Apr 11, 2017

@jasnell in general I think the more warning we can give people the better. This may be a bit of a special situation where Power Linux essentially switched the primary endianess and there were both options for a transition period. I suggest we land this but then discuss in the LTS team what we want the standard process to be. We should probably also do the same in terms of OS versions.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Apr 11, 2017

Member

will plan to land unless I hear objections once the 24 hours is up.

Member

mhdawson commented Apr 11, 2017

will plan to land unless I hear objections once the 24 hours is up.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 11, 2017

Member

Sounds good

Member

jasnell commented Apr 11, 2017

Sounds good

@mhdawson

This comment has been minimized.

Show comment
Hide comment

mhdawson added a commit that referenced this pull request Apr 12, 2017

doc: drop PPC BE from supported platforms
We've discussed this with the Power team within IBM and have
agreement that we should drop Power Linux BE for Node version
8 as customers will be using Power Linux LE when using
Node.js going forward.

PR-URL: #12309
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: Jaideep Bajwa <bjaideep@ca.ibm.com>
@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson Apr 12, 2017

Member

Landed in 75c471a

Member

mhdawson commented Apr 12, 2017

Landed in 75c471a

@mhdawson mhdawson closed this Apr 12, 2017

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@mhdawson mhdawson deleted the mhdawson:dropbe branch Jun 28, 2017

@richardlau richardlau referenced this pull request Feb 23, 2018

Closed

deps: update V8 to 6.5 #18453

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment