Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage for n-api #12327

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
6 participants
@mhdawson
Copy link
Member

commented Apr 11, 2017

Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]
Affected core subsystem(s)

test, n-api

test: improve test coverage for n-api
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

@mscdex mscdex added the n-api label Apr 11, 2017

const assert = require('assert');

// testing handle scope api calls
const test_handle_scope =

This comment has been minimized.

Copy link
@cjihrig

cjihrig Apr 11, 2017

Contributor

Can you use camelCase in the JS code.

This comment has been minimized.

Copy link
@mhdawson

mhdawson Apr 11, 2017

Author Member

sure just copied other existing test as a base, but that's not a good reason :). Updating

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 11, 2017

Pushed commit to address switch to camel case in js.

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2017

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2017

Landed as 0ec0272

@mhdawson mhdawson closed this Apr 12, 2017

mhdawson added a commit that referenced this pull request Apr 12, 2017

test: improve test coverage for n-api
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

PR-URL: #12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@mhdawson mhdawson deleted the mhdawson:napi-cov1 branch Jun 28, 2017

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 11, 2018

test: improve test coverage for n-api
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

PR-URL: nodejs#12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018

test: improve test coverage for n-api
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

PR-URL: nodejs#12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018

test: improve test coverage for n-api
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

PR-URL: nodejs#12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Apr 16, 2018

test: improve test coverage for n-api
Add basic tests for handle scopes as code coverage
reports that we are not covering these with the existing
tests.

Backport-PR-URL: #19447
PR-URL: #12327
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Apr 16, 2018

Merged

v6.14.2 proposal #19996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.