Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove experimental warning for inspect #12352

Closed
wants to merge 1 commit into from

Conversation

@MylesBorins
Copy link
Member

commented Apr 12, 2017

  • Removes "experimental" warning.

This is broken out of #11207 which also included changes to the message the inspector prints.

@joshgav's authorship is maintained on the commit

CI: https://ci.nodejs.org/job/node-test-pull-request/7343/

@MylesBorins MylesBorins referenced this pull request Apr 12, 2017
4 of 4 tasks complete

@MylesBorins MylesBorins added this to the 8.0.0 milestone Apr 12, 2017

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2017

/cc @jasnell

@MylesBorins MylesBorins force-pushed the MylesBorins:stable-inspect branch 2 times, most recently Apr 12, 2017

@MylesBorins MylesBorins force-pushed the MylesBorins:stable-inspect branch Apr 12, 2017

@MylesBorins MylesBorins changed the title src: remove experiment warning for inspect src: remove experimental warning for inspect Apr 12, 2017

@MylesBorins MylesBorins requested review from eugeneo, jasnell and joshgav Apr 12, 2017

src: remove experimental warning for inspect
* Removes "experimental" warning.

Fixes: #11770
PR-URL: #12352
Reviewed-By: _tbd_
Reviewed-By: _tbd_
@jasnell
Copy link
Member

left a comment

Lgtm!

@MylesBorins MylesBorins force-pushed the MylesBorins:stable-inspect branch to 4e6fdcd Apr 12, 2017

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 12, 2017

Looks like some ci failures tho

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2017

Got a little overzealous removing things. Should work fine now... CI kicked off once more

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 12, 2017

Remove all the things!

@targos
targos approved these changes Apr 12, 2017
@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2017

Are people ok with this landed in less than 48 hours?

@evanlucas
Copy link
Member

left a comment

LGTM

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 12, 2017

I'm good with it, yes. It would be good to get this in before I do the RC.0 build

@aqrln
aqrln approved these changes Apr 12, 2017
@Fishrock123

This comment has been minimized.

Copy link
Member

commented Apr 12, 2017

I personally would greatly prefer if some sort of generic URL was printed along with this change, not sure if that is standardized enough yet?

@MylesBorins

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2017

@Fishrock123 there is another thread for changing the message, we couldn't reach consensus on that so I wanted to get this in first

jasnell added a commit that referenced this pull request Apr 13, 2017
src: remove experimental warning for inspect
* Removes "experimental" warning.

Fixes: #11770
PR-URL: #12352
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

Landed in a4125a3

@jasnell jasnell closed this Apr 13, 2017

@jkrems jkrems referenced this pull request Apr 13, 2017
14 of 14 tasks complete
cjihrig added a commit to cjihrig/node-1 that referenced this pull request Apr 14, 2017
@cjihrig cjihrig referenced this pull request Apr 14, 2017
3 of 3 tasks complete
jasnell added a commit that referenced this pull request Apr 17, 2017
doc: remove inspector experimental warning
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas added a commit that referenced this pull request Apr 25, 2017
doc: remove inspector experimental warning
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas added a commit that referenced this pull request May 1, 2017
doc: remove inspector experimental warning
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas added a commit that referenced this pull request May 2, 2017
doc: remove inspector experimental warning
PR-URL: #12408
Ref: #12352
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017

@MylesBorins MylesBorins deleted the MylesBorins:stable-inspect branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.