Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
src: reduce number of exported symbols #12366
Affected core subsystem(s)
Apr 12, 2017
Only if they were relying on these symbols on purpose – so far we’ve always been taking the liberty of changing code that’s guarded by
That's why I dubbed them "rogue"... I've been know to use undocumented entry points on occasion
Everything I have seen so far indicates that our embedders and addon developers avoid doing that. (Also, I strongly doubt anything in here would be useful for outside users.)
This doesn’t touch our public API, so it’s semver-nothing, and I really don’t think this is worth an explicit mention in the release notes. If you feel really strongly about it, we can only land it in Node 8, I don’t care too much.
(edited a bit later)
I agree it's semver-nothing, and I don't feel too strongly one way or another.
Just an example in the description of #8749 is says "Any non-null value of NODE_PRESERVE_SYMLINKS will enable symlinks." even tough the code acts differently and is documented correctly, that caused me a few hours of frustration, with no-one to blame but myself...
Landed in 9d52222
@benjamingr Like I’ve said, we’ve been quite liberal with internals so far, so it would be very surprising if this broke some actual code. I’ve added the dont-land labels because it shouldn’t really matter, but I would like to avoid getting in a habit of considering these actual breaking changes.
(edit: if this makes it into a release < 8.x it should probably come together with #12432)