Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: upgrade Clang requirement to 3.4.2 #12388

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

commented Apr 13, 2017

Clang 3.4.1 has a bug that prevents compilation of V8.
As of Node.js 8.0.0 we stopped floating a workaround for this issue.

I don't have a test system to check if 3.4.2 is enough.

/cc @nodejs/build

Checklist
doc: upgrade Clang requirement to 3.4.2
Clang 3.4.1 has a bug that prevents compilation of V8.
As of Node.js 8.0.0 we stopped floating a workaround for this issue.
@bnoordhuis
Copy link
Member

left a comment

LGTM and good catch on configure.

I'd be okay with raising the baseline to 3.5.2 or 3.6.2 for node 8. We'll be supporting it until 2021, it would make sense to start with a compiler that's not already long in the tooth.

@mhdawson

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

In terms 3.5.2 and 3.6.2 will those run on the existing OS levels were Clang is used in our regression runs ?

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

I'm all for raising the bar in node 8 as well. ubuntu trusty seems to offer clang 3.4, 3.5, 3.6 and 3.8.

Any arguments on 3.5.x vs 3.6.x?

@benjamingr
Copy link
Member

left a comment

LGTM

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

In terms 3.5.2 and 3.6.2 will those run on the existing OS levels were Clang is used in our regression runs ?

I'd say so. I don't think we have any systems in our matrix where you can install 3.4 but not 3.5 or 3.6.

Any arguments on 3.5.x vs 3.6.x?

PPC support got a big boost in 3.6. Might be worth it for that reason alone.

@jbergstroem

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

@bnoordhuis said:
PPC support got a big boost in 3.6. Might be worth it for that reason alone.

Sounds good to me. The newer, the better.

@refack refack force-pushed the nodejs:master branch to fbe946b Apr 14, 2017

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

CI since there's a change in the configure script here: https://ci.nodejs.org/job/node-test-pull-request/7489/

@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

CI failure is unrelated

@mhdawson
Copy link
Member

left a comment

LGTM

jasnell added a commit that referenced this pull request Apr 18, 2017
doc: upgrade Clang requirement to 3.4.2
Clang 3.4.1 has a bug that prevents compilation of V8.
As of Node.js 8.0.0 we stopped floating a workaround for this issue.

PR-URL: #12388
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

Landed in b4f59a7

@jasnell jasnell closed this Apr 18, 2017

@jasnell jasnell referenced this pull request May 11, 2017

@targos targos deleted the targos:clang-342 branch Jun 1, 2017

@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

I'm assuming this doesn't apply to v7 and earlier, LMK if that's not correct.

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Jun 19, 2017

We carry a compatibility patch in older branches although it's no longer tested now that the clang 3.4.1 buildbot has been decommissioned. I'd back-port this PR, that way people know what the known-good version of clang is.

gibfahn added a commit that referenced this pull request Jun 20, 2017
doc: upgrade Clang requirement to 3.4.2
Clang 3.4.1 has a bug that prevents compilation of V8.
As of Node.js 8.0.0 we stopped floating a workaround for this issue.

PR-URL: #12388
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 20, 2017

Backported in 11a7875

@gibfahn gibfahn added land-on-v6.x and removed lts-watch-v6.x labels Jun 20, 2017

MylesBorins added a commit that referenced this pull request Jul 11, 2017
doc: upgrade Clang requirement to 3.4.2
Clang 3.4.1 has a bug that prevents compilation of V8.
As of Node.js 8.0.0 we stopped floating a workaround for this issue.

PR-URL: #12388
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.