crypto: remove unused code in sign/verify #12397

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
@tniessen
Member

tniessen commented Apr 13, 2017

Removes unused code in node_crypto.cc in Sign::SignFinal and Verify::VerifyFinal as suggested by @addaleax here.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@sam-github

Code looks ok if its passing tests, but the commit message could say something more specific. Was there an encoding arg supported by the C++ layer that was always being passed null, and you removed that?

@addaleax

Looks good, but I agree that the commit message could be a bit more specific

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Apr 13, 2017

Member

@sam-github @addaleax I tried to do better this time. Yes, it is about an unused encoding parameter in both methods.

Member

tniessen commented Apr 13, 2017

@sam-github @addaleax I tried to do better this time. Yes, it is about an unused encoding parameter in both methods.

@sam-github

Thanks, nice commit message. Maybe subject could be more specific, like "crypto: remove unused C++ arg in sign/verify" if its < 50 chars, but I'm good with this message as-is.

crypto: remove unused C++ parameter in sign/verify
Removes code in node_crypto.cc in Sign::SignFinal and
Verify::VerifyFinal which allowed to convert between buffers and
strings based on given encodings. The code is unused as crypto.js
only passes in and expects buffers and does the conversion itself.
The encoding parameter was removed from both methods.
@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Apr 13, 2017

Member

@sam-github I changed the subject to "crypto: remove unused C++ parameter in sign/verify" (50 chars) but will wait for CI to finish after experiencing problems with CI and force-pushs.

Member

tniessen commented Apr 13, 2017

@sam-github I changed the subject to "crypto: remove unused C++ parameter in sign/verify" (50 chars) but will wait for CI to finish after experiencing problems with CI and force-pushs.

@tniessen

This comment has been minimized.

Show comment
Hide comment
@tniessen

tniessen Apr 13, 2017

Member

CI passed, subject changed.

Member

tniessen commented Apr 13, 2017

CI passed, subject changed.

@jasnell

LGTM if CI is passing.

@jasnell

This comment has been minimized.

Show comment
Hide comment

jasnell added a commit that referenced this pull request Apr 18, 2017

crypto: remove unused C++ parameter in sign/verify
Removes code in node_crypto.cc in Sign::SignFinal and
Verify::VerifyFinal which allowed to convert between buffers and
strings based on given encodings. The code is unused as crypto.js
only passes in and expects buffers and does the conversion itself.
The encoding parameter was removed from both methods.

PR-URL: #12397
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 18, 2017

Member

Landed in eaa0542

Member

jasnell commented Apr 18, 2017

Landed in eaa0542

@jasnell jasnell closed this Apr 18, 2017

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request in nodejs/Release Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 18, 2017

Member

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Member

gibfahn commented Jun 18, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment