Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: changed equality comparison to identity operator #12405

Closed
wants to merge 1 commit into from

Conversation

@fcampinho
Copy link
Contributor

commented Apr 13, 2017

test: changed equality comparison to identity operator

Changed the equality comparison from == to identity operator ===

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@mscdex mscdex added the crypto label Apr 13, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2017

@Trott
Trott approved these changes Apr 13, 2017
Copy link
Member

left a comment

LGTM if CI is green

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

Minor nit for whoever lands this (or if @fcampinho wants to fix it up and force push, that's cool too): First word of the commit message should be an imperative verb, so changed should be change.

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

Minor nit part 2: The first line should be 50 chars max so maybe test: change == to === in crypto test or something like that

test: change == to === in crypto test
Changed the equality comparison from == to identity operator ===

@fcampinho fcampinho force-pushed the fcampinho:teste-crypt-coperator branch to 949fa58 Apr 13, 2017

@fcampinho

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2017

Sorry @Trott , first commit, I executed a git push --force

@refack refack force-pushed the nodejs:master branch to fbe946b Apr 14, 2017

@aqrln
aqrln approved these changes Apr 15, 2017
Trott added a commit to Trott/io.js that referenced this pull request Apr 16, 2017
test: change == to === in crypto test
Changed the equality comparison from == to identity operator ===

PR-URL: nodejs#12405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Apr 16, 2017

Landed in 7044065

@Trott Trott closed this Apr 16, 2017

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 16, 2017

Thanks for the contribution! 🎉

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Should land after #11705

@gibfahn gibfahn referenced this pull request Jun 18, 2017
4 of 4 tasks complete
tniessen added a commit to tniessen/node that referenced this pull request Jul 21, 2017
test: change == to === in crypto test
Changed the equality comparison from == to identity operator ===

PR-URL: nodejs#12405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 16, 2017
test: change == to === in crypto test
Changed the equality comparison from == to identity operator ===

PR-URL: #12405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@MylesBorins MylesBorins referenced this pull request Oct 17, 2017
MylesBorins added a commit that referenced this pull request Oct 25, 2017
test: change == to === in crypto test
Changed the equality comparison from == to identity operator ===

PR-URL: #12405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@MylesBorins MylesBorins referenced this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.