deps: cherry-pick 79aee39 from upstream v8 #12412

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
6 participants
@bnoordhuis
Member

bnoordhuis commented Apr 14, 2017

This is a chery-pick if you consider reducing the context to -C2
a cherry-pick; WordIsSmi has been renamed to TaggedIsSmi upstream.

Original commit message:

[builtins] Fix pointer comparison in ToString builtin.

This fixes the bogus {Word32Equal} comparison in the ToString
builtin implementing Object.prototype.toString to be a pointer-size
{WordEqual} comparison instead. Comparing just the lower half-word
is insufficient on 64-bit architectures.

R=jgruber@chromium.org
TEST=mjsunit/regress/regress-crbug-664506
BUG=chromium:664506

Review-Url: https://codereview.chromium.org/2496043003
Cr-Commit-Position: refs/heads/master@{#40963}

Node CI: https://ci.nodejs.org/job/node-test-pull-request/7400/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/647/

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 17, 2017

Member

The one failure in CI looks unrelated but @bnoordhuis can you please take a look and confirm

Member

jasnell commented Apr 17, 2017

The one failure in CI looks unrelated but @bnoordhuis can you please take a look and confirm

@thefourtheye

This comment has been minimized.

Show comment
Hide comment
@thefourtheye

thefourtheye Apr 18, 2017

Contributor

@jasnell I think that is seen in #12392 as well

Contributor

thefourtheye commented Apr 18, 2017

@jasnell I think that is seen in #12392 as well

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Apr 19, 2017

Member

The one failure in CI looks unrelated but @bnoordhuis can you please take a look and confirm

It's that no member named 'max_align_t' error that happens at random on the ubuntu1204-clang341-64 buildbot. The file it complains about hasn't changed in years.

Member

bnoordhuis commented Apr 19, 2017

The one failure in CI looks unrelated but @bnoordhuis can you please take a look and confirm

It's that no member named 'max_align_t' error that happens at random on the ubuntu1204-clang341-64 buildbot. The file it complains about hasn't changed in years.

deps: cherry-pick 79aee39 from upstream v8
This is a chery-pick if you consider reducing the context to -C2
a cherry-pick; WordIsSmi has been renamed to TaggedIsSmi upstream.

Original commit message:

    [builtins] Fix pointer comparison in ToString builtin.

    This fixes the bogus {Word32Equal} comparison in the ToString
    builtin implementing Object.prototype.toString to be a pointer-size
    {WordEqual} comparison instead. Comparing just the lower half-word
    is insufficient on 64-bit architectures.

    R=jgruber@chromium.org
    TEST=mjsunit/regress/regress-crbug-664506
    BUG=chromium:664506

    Review-Url: https://codereview.chromium.org/2496043003
    Cr-Commit-Position: refs/heads/master@{#40963}

Fixes: #12411
PR-URL: #12412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

@bnoordhuis bnoordhuis merged commit f882f47 into nodejs:v7.x-staging Apr 19, 2017

@bnoordhuis bnoordhuis deleted the bnoordhuis:fix12411 branch Apr 19, 2017

@gibfahn gibfahn referenced this pull request in nodejs/build Apr 24, 2017

Closed

ubuntu1204-clang341 has been disabled in CI #685

@evanlucas evanlucas referenced this pull request May 1, 2017

Merged

v7.10.0 proposal #12775

evanlucas added a commit that referenced this pull request May 1, 2017

deps: cherry-pick 79aee39 from upstream v8
This is a chery-pick if you consider reducing the context to -C2
a cherry-pick; WordIsSmi has been renamed to TaggedIsSmi upstream.

Original commit message:

    [builtins] Fix pointer comparison in ToString builtin.

    This fixes the bogus {Word32Equal} comparison in the ToString
    builtin implementing Object.prototype.toString to be a pointer-size
    {WordEqual} comparison instead. Comparing just the lower half-word
    is insufficient on 64-bit architectures.

    R=jgruber@chromium.org
    TEST=mjsunit/regress/regress-crbug-664506
    BUG=chromium:664506

    Review-Url: https://codereview.chromium.org/2496043003
    Cr-Commit-Position: refs/heads/master@{#40963}

Fixes: #12411
PR-URL: #12412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins May 15, 2017

Member

should this be backported to v6.x?

Member

MylesBorins commented May 15, 2017

should this be backported to v6.x?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis May 15, 2017

Member

No, v4.x and v6.x aren't affected, AFAIK.

Member

bnoordhuis commented May 15, 2017

No, v4.x and v6.x aren't affected, AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment