Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix: removed < in changelog.md #12434

Closed
wants to merge 1 commit into from

Conversation

@gautamkrishnar
Copy link
Contributor

commented Apr 15, 2017

Fixing a typo....
Fixes:#12430

@gibfahn

This comment has been minimized.

Copy link
Member

commented Apr 15, 2017

Change looks good but could you format your commit message according to the Contributing Guidelines?

Maybe something like this?

doc: fix typo in CHANGELOG.md

Fixes: https://github.com/nodejs/node/issues/12430

If you don't have time it can be rewritten by whoever lands this, but if you are going to help out more on the project (as I hope you do), then it saves work if you produce better commit messages.

CHANGELOG.md Outdated
@@ -29,7 +29,7 @@ release.
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V7.md#7.9.0">7.9.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.8.0<">7.8.0<</a><br/>
<a href="doc/changelogs/CHANGELOG_V7.md#7.8.0<">7.8.0</a><br/>

This comment has been minimized.

Copy link
@TimothyGu

TimothyGu Apr 15, 2017

Member

Would you mind fixing the extra < after the CHANGELOG_V7.md#7.8.0 as well?

This comment has been minimized.

Copy link
@gautamkrishnar

gautamkrishnar Apr 15, 2017

Author Contributor

Did it 👍

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2017

LGTM

@gautamkrishnar gautamkrishnar force-pushed the gautamkrishnar:patch-1 branch to 6097535 Apr 16, 2017

@gautamkrishnar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2017

@gibfahn Reworded and squashed 🔪
Thanks for informing me about the guidelines... Yes i would like to contribute my best ❤️

@TimothyGu

This comment has been minimized.

Copy link
Member

commented Apr 16, 2017

Landed in b837bd2.

@gautamkrishnar next time, make sure to include

Fixes: https://github.com/nodejs/node/issues/12430

in your commit message as well.

@TimothyGu TimothyGu closed this Apr 16, 2017

TimothyGu added a commit that referenced this pull request Apr 16, 2017
doc: fix typo in CHANGELOG.md
PR-URL: #12434
Fixes: #12430
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

@gautamkrishnar gautamkrishnar deleted the gautamkrishnar:patch-1 branch Apr 16, 2017

@gautamkrishnar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2017

@TimothyGu thanks for correcting me. I will surely do that next time...

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.