New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: bump gyp to eb296f6 #12450

Closed
wants to merge 0 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@refack
Member

refack commented Apr 16, 2017

Bump GYP to eb296f6
Re float all patches since last bump - 1d65b99

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools,build,gyp

@refack

This comment has been minimized.

Show comment
Hide comment
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Apr 16, 2017

Member

deps: float gyp patch for long filenames 592f89a

It should be safe to drop this now, the patch has been applied upstream

build: enable cctest to use generated objects 6ed488a

This commit seems noticeably different from the original? It might be a hint for solving @gibfahn’s #12448, though…

Member

addaleax commented Apr 16, 2017

deps: float gyp patch for long filenames 592f89a

It should be safe to drop this now, the patch has been applied upstream

build: enable cctest to use generated objects 6ed488a

This commit seems noticeably different from the original? It might be a hint for solving @gibfahn’s #12448, though…

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 16, 2017

Member

/cc @nodejs/build @addaleax @shigeki @jbergstroem @danbev
Do you know of any older than 1d65b99 patches that might need to be reapplied?

Member

refack commented Apr 16, 2017

/cc @nodejs/build @addaleax @shigeki @jbergstroem @danbev
Do you know of any older than 1d65b99 patches that might need to be reapplied?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 16, 2017

Member

build: enable cctest to use generated objects 6ed488a

This commit seems noticeably different from the original? It might be a hint for solving @gibfahn’s #12448, though…

Was a mixed core + GYP commit (see my #11956 (comment)) I picked just the GYP part

Member

refack commented Apr 16, 2017

build: enable cctest to use generated objects 6ed488a

This commit seems noticeably different from the original? It might be a hint for solving @gibfahn’s #12448, though…

Was a mixed core + GYP commit (see my #11956 (comment)) I picked just the GYP part

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 16, 2017

Member

deps: float gyp patch for long filenames 592f89a

It should be safe to drop this now, the patch has been applied upstream

Dropped

Member

refack commented Apr 16, 2017

deps: float gyp patch for long filenames 592f89a

It should be safe to drop this now, the patch has been applied upstream

Dropped

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Apr 16, 2017

Member

Was a mixed core + GYP commit (see my #11956 (comment)) I picked just the GYP part

I see that, but including it like this still seems a little misleading… at least the commit message and the PR-URL should probably be different here, to avoid confusion with the original commit.

Member

addaleax commented Apr 16, 2017

Was a mixed core + GYP commit (see my #11956 (comment)) I picked just the GYP part

I see that, but including it like this still seems a little misleading… at least the commit message and the PR-URL should probably be different here, to avoid confusion with the original commit.

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 16, 2017

Member

I see that, but including it like this still seems a little misleading… at least the commit message and the PR-URL should probably be different here, to avoid confusion with the original commit.

gotcha

Member

refack commented Apr 16, 2017

I see that, but including it like this still seems a little misleading… at least the commit message and the PR-URL should probably be different here, to avoid confusion with the original commit.

gotcha

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 16, 2017

Member

@addaleax bb49593 better?

Member

refack commented Apr 16, 2017

@addaleax bb49593 better?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 16, 2017

Member

As for the PR URL, I think it should stay since it's the actual motivation for the change. I'm just re-applying it in the context of GYP
I guess both should be there.

Member

refack commented Apr 16, 2017

As for the PR URL, I think it should stay since it's the actual motivation for the change. I'm just re-applying it in the context of GYP
I guess both should be there.

@shigeki

This comment has been minimized.

Show comment
Hide comment
@shigeki

shigeki Apr 17, 2017

Contributor

I only know the XCode floating patch that is included in this PR. I'm not sure if other else patches are needed.
As for the XCode patch, @bnoordhuis submitted the patch to the upstream in https://codereview.chromium.org/1213123002/ but it's been stalled.

Contributor

shigeki commented Apr 17, 2017

I only know the XCode floating patch that is included in this PR. I'm not sure if other else patches are needed.
As for the XCode patch, @bnoordhuis submitted the patch to the upstream in https://codereview.chromium.org/1213123002/ but it's been stalled.

@joaocgreis

This comment has been minimized.

Show comment
Hide comment
@joaocgreis

joaocgreis Apr 17, 2017

Member

tools/gyp/buildbot/aosp_manifest.xml, tools/gyp/pylib/gyp/generator/android.py and tools/gyp/pylib/gyp/generator/compile_commands_json.py are not present upstream, should be deleted in the first commit.

Isn't 3c46bb9 needed as well?

@refack about the partial commit message, it would be good to use a format similar to 5111e78, with the original message indented. Metadata should be at the end, so that core-validate-commit passes, and you probably want to avoid @-mentioning in the commit message because you'll get a notification every time this is rebased or cherry-picked.

Member

joaocgreis commented Apr 17, 2017

tools/gyp/buildbot/aosp_manifest.xml, tools/gyp/pylib/gyp/generator/android.py and tools/gyp/pylib/gyp/generator/compile_commands_json.py are not present upstream, should be deleted in the first commit.

Isn't 3c46bb9 needed as well?

@refack about the partial commit message, it would be good to use a format similar to 5111e78, with the original message indented. Metadata should be at the end, so that core-validate-commit passes, and you probably want to avoid @-mentioning in the commit message because you'll get a notification every time this is rebased or cherry-picked.

@aqrln

This comment has been minimized.

Show comment
Hide comment
@aqrln

aqrln Apr 17, 2017

Member

@refack

As for the PR URL, I think it should stay since it's the actual motivation for the change. I'm just re-applying it in the context of GYP

I believe there's no need in the original metadata since the original commit hash is present in the commit message and it's easy to do git show locally or just click a link on GitHub. Yeah, by the way, that hash is wrong in your last commit.

Member

aqrln commented Apr 17, 2017

@refack

As for the PR URL, I think it should stay since it's the actual motivation for the change. I'm just re-applying it in the context of GYP

I believe there's no need in the original metadata since the original commit hash is present in the commit message and it's easy to do git show locally or just click a link on GitHub. Yeah, by the way, that hash is wrong in your last commit.

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 17, 2017

Member

@joaocgreis 3c46bb9 added. As for the partial commit, I'm with @aqrln, same tree, so just a pointer.

Member

refack commented Apr 17, 2017

@joaocgreis 3c46bb9 added. As for the partial commit, I'm with @aqrln, same tree, so just a pointer.

@refack

This comment has been minimized.

Show comment
Hide comment
Member

refack commented Apr 17, 2017

@aqrln

This comment has been minimized.

Show comment
Hide comment
@aqrln

aqrln Apr 17, 2017

Member

@refack still wrong commit hash. 6a09a69 is what you want ;)

Member

aqrln commented Apr 17, 2017

@refack still wrong commit hash. 6a09a69 is what you want ;)

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 17, 2017

Member

@refack still wrong commit hash. 6a09a69 is what you want ;)

GitHub is a mysterious place, where does f5a9b16 exist?

Member

refack commented Apr 17, 2017

@refack still wrong commit hash. 6a09a69 is what you want ;)

GitHub is a mysterious place, where does f5a9b16 exist?

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax Apr 17, 2017

Member

where does f5a9b16 exist?

$ git for-each-ref --contains f5a9b16910878e35eb36f551ed6790c2ed8006f1
2d9967c1c6177c6e9273d6a87bd5ea99571afd74 commit	refs/remotes/upstream/pr/11956

#11956, where it came from :)

Member

addaleax commented Apr 17, 2017

where does f5a9b16 exist?

$ git for-each-ref --contains f5a9b16910878e35eb36f551ed6790c2ed8006f1
2d9967c1c6177c6e9273d6a87bd5ea99571afd74 commit	refs/remotes/upstream/pr/11956

#11956, where it came from :)

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 17, 2017

Member

So GitHub creates pseudo-branches for PRs, independent of originating branch... I suspected so after I accidently patched #12231

Member

refack commented Apr 17, 2017

So GitHub creates pseudo-branches for PRs, independent of originating branch... I suspected so after I accidently patched #12231

@aqrln

This comment has been minimized.

Show comment
Hide comment
@aqrln

aqrln Apr 17, 2017

Member

@refack as Anna has just noted, in the PR, obviously :) But you don't want to link to the commit from the PR branch, you rather need the commit that has been landed to master.

UPD: oops, I think I'm late for a second with my answer.

Member

aqrln commented Apr 17, 2017

@refack as Anna has just noted, in the PR, obviously :) But you don't want to link to the commit from the PR branch, you rather need the commit that has been landed to master.

UPD: oops, I think I'm late for a second with my answer.

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 17, 2017

Member

@refack as Anna has just noted, in the PR, obviously :) But you don't want to link to the commit from the PR branch, you rather need the commit that has been landed to master.

Yes obviously, I assumed the commit in the PR wouldn't be on the nodejs/node tree but in a fork, that's what threw me off.

Member

refack commented Apr 17, 2017

@refack as Anna has just noted, in the PR, obviously :) But you don't want to link to the commit from the PR branch, you rather need the commit that has been landed to master.

Yes obviously, I assumed the commit in the PR wouldn't be on the nodejs/node tree but in a fork, that's what threw me off.

@aqrln

This comment has been minimized.

Show comment
Hide comment
@aqrln

aqrln Apr 17, 2017

Member

@refack GitHub creates refs for all the PRs. You can even fetch them like that:

$ git fetch upstream +refs/pull/PR_ID/head:refs/remotes/upstream/pr/PR_ID

(the local part after the colon shouldn't necessarily look exactly like that, you can fetch that to whatever local ref you'd prefer to, that's just how people usually do it).

Member

aqrln commented Apr 17, 2017

@refack GitHub creates refs for all the PRs. You can even fetch them like that:

$ git fetch upstream +refs/pull/PR_ID/head:refs/remotes/upstream/pr/PR_ID

(the local part after the colon shouldn't necessarily look exactly like that, you can fetch that to whatever local ref you'd prefer to, that's just how people usually do it).

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 17, 2017

Member

$ git fetch upstream +refs/pull/PR_ID/head:refs/remotes/upstream/pr/PR_ID

This I do on ocation, but I assumed it's an alias. Have you ever tried to push this way? PRing a PR?

Member

refack commented Apr 17, 2017

$ git fetch upstream +refs/pull/PR_ID/head:refs/remotes/upstream/pr/PR_ID

This I do on ocation, but I assumed it's an alias. Have you ever tried to push this way? PRing a PR?

@aqrln

This comment has been minimized.

Show comment
Hide comment
@aqrln

aqrln Apr 17, 2017

Member

@refack nope, I haven't tried it, but it should work. Why shouldn't it?

Member

aqrln commented Apr 17, 2017

@refack nope, I haven't tried it, but it should work. Why shouldn't it?

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 17, 2017

Member

@refack nope, I haven't tried it, but it should work. Why shouldn't it?

This makes me think we could re-flow our landing process.

  1. fetch PR
  2. rebase + message edit + validate + test
  3. push PR
  4. Use "Rebase & Merge" button, so PR turn purple rather than red
Member

refack commented Apr 17, 2017

@refack nope, I haven't tried it, but it should work. Why shouldn't it?

This makes me think we could re-flow our landing process.

  1. fetch PR
  2. rebase + message edit + validate + test
  3. push PR
  4. Use "Rebase & Merge" button, so PR turn purple rather than red
@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Jun 18, 2017

Member

3fe980d (typo)
&
780acc2 (tooling edge case)
Both are minor

Member

refack commented Jun 18, 2017

3fe980d (typo)
&
780acc2 (tooling edge case)
Both are minor

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 18, 2017

Member

I meant bugs that haven't been fixed (and can't be backported as part of the same PR) 😁 .

Go ahead and open it, if people have issues they can comment on the PR.

Member

gibfahn commented Jun 18, 2017

I meant bugs that haven't been fixed (and can't be backported as part of the same PR) 😁 .

Go ahead and open it, if people have issues they can comment on the PR.

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 12, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 12, 2017

build: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs#11956
Original-Ref: nodejs#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 18, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

sam-github pushed a commit to sam-github/node that referenced this pull request Jul 18, 2017

build: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs#11956
Original-Ref: nodejs#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Jul 18, 2017

tools: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Jul 18, 2017

build: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs#11956
Original-Ref: nodejs#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 9, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 9, 2017

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs#11956
Original-Ref: nodejs#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 19, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 19, 2017

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs#11956
Original-Ref: nodejs#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 23, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs#7986
PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

refack added a commit to refack/node that referenced this pull request Aug 23, 2017

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs#11956
Original-Ref: nodejs#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#12450
Reviewed-By: João Reis <reis@janeasystems.com>

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs/node#7986
PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

addaleax added a commit to addaleax/ayo that referenced this pull request Aug 25, 2017

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs/node#11956
Original-Ref: nodejs/node#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs/node#7986
PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

addaleax added a commit to ayojs/ayo that referenced this pull request Aug 28, 2017

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs/node#11956
Original-Ref: nodejs/node#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: #11956
Original-Ref: #9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: #7986
PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>

MylesBorins added a commit that referenced this pull request Sep 12, 2017

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: #11956
Original-Ref: #9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #12450
Reviewed-By: João Reis <reis@janeasystems.com>
@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Jan 11, 2018

Member

ping re: v6.x backport

Member

MylesBorins commented Jan 11, 2018

ping re: v6.x backport

maclover7 added a commit to maclover7/node-gyp that referenced this pull request Jul 31, 2018

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9931ecea71167342322e09121ee48cde8e
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs/node#7986
PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 added a commit to maclover7/node-gyp that referenced this pull request Jul 31, 2018

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69ec9d36b705e9bde2ac1a193566a702d96
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs/node#11956
Original-Ref: nodejs/node#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

rvagg added a commit to nodejs/node-gyp that referenced this pull request Aug 9, 2018

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9931ecea71167342322e09121ee48cde8e
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs/node#7986
PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

rvagg added a commit to nodejs/node-gyp that referenced this pull request Aug 9, 2018

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69ec9d36b705e9bde2ac1a193566a702d96
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs/node#11956
Original-Ref: nodejs/node#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

rvagg added a commit to nodejs/node-gyp that referenced this pull request Aug 9, 2018

gyp: add compile_commands.json gyp generator
this is a re-base of the gyp part of
3c46bb9931ecea71167342322e09121ee48cde8e
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-Review-By: James M Snell <jasnell@gmail.com>
Ref: nodejs/node#7986
PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>

rvagg added a commit to nodejs/node-gyp that referenced this pull request Aug 9, 2018

gyp: enable cctest to use objects (gyp part)
this is a re-base of the gyp part of
6a09a69ec9d36b705e9bde2ac1a193566a702d96
after bumping GYP version to
https://chromium.googlesource.com/external/gyp/+/eb296f67da078ec01f5e3a9ea9cdc6d26d680161

Original-PR-URL: nodejs/node#11956
Original-Ref: nodejs/node#9163
Original-Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs/node#12450
Reviewed-By: João Reis <reis@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment