Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove common.PORT from shared,master,rr tests #12451

Closed
wants to merge 2 commits into from

Conversation

@tarunbatra
Copy link
Contributor

commented Apr 16, 2017

Refs: #12376
PR_URL: #12451

Tests updated:

  • test/parallel/test-cluster-shared-leak.js
  • test/parallel/test-cluster-master-error.js
  • test/parallel/test-cluster-master-kill.js
  • test/parallel/test-cluster-net-send.js
  • test/parallel/test-cluster-rr-domain-listen.js
  • test/parallel/test-cluster-rr-ref.js
  • test/parallel/test-cluster-worker-no-exit.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@santigimeno
Copy link
Member

left a comment

It looks good. Just to be sure the test behaves as originally intended, I would check that it fails in nodejs version 4.2.1 on an OS other than linux as it's pointed out in the description of the test.

test/parallel/test-cluster-shared-leak.js Outdated
worker2 = cluster.fork();
worker2.on('online', function() {
conn = net.connect(common.PORT, common.mustCall(function() {
conn = net.connect(worker.port, common.mustCall(function() {

This comment has been minimized.

Copy link
@santigimeno

santigimeno Apr 16, 2017

Member

I would rename worker to address.

This comment has been minimized.

Copy link
@tarunbatra

tarunbatra Apr 16, 2017

Author Contributor

Yeah, that makes sense. Changing.

@santigimeno santigimeno added the cluster label Apr 16, 2017

@tarunbatra

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2017

@santigimeno Yes I saw the comment and I'm curious too, but I don't have access to another OS.

@santigimeno
Copy link
Member

left a comment

@tarunbatra I can confirm it also fails as expected with the new version of the test using nodejs@4.2.1 on OS.X. LGTM

@tarunbatra

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2017

@santigimeno great. Thanx! I'll try to use similar pattern in other test files.

@tarunbatra

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2017

@santigimeno What should be preferred, more commits to this PR or a new PR for small changes to other files regarding the same issue #12376 ?

@santigimeno

This comment has been minimized.

Copy link
Member

commented Apr 16, 2017

@tarunbatra if the changes are similar I would group them, but as you prefer :).

test: remove common.PORT from master,rr tests
Files changed:
 * test/parallel/test-cluster-master-error.js
 * test/parallel/test-cluster-master-kill.js
 * test/parallel/test-cluster-net-send.js
 * test/parallel/test-cluster-rr-domain-listen.js
 * test/parallel/test-cluster-rr-ref.js
 * test/parallel/test-cluster-worker-no-exit.js

Refs: #12376
PR_URL: #12451

@tarunbatra tarunbatra changed the title tests: remove common.PORT from shared leak test [WIP] tests: remove common.PORT from shared,master,rr tests Apr 16, 2017

@Trott Trott referenced this pull request Apr 16, 2017
55 of 64 tasks complete
@ghost
ghost approved these changes Apr 17, 2017
@lpinca
lpinca approved these changes Apr 17, 2017
@benjamingr

This comment has been minimized.

jasnell added a commit that referenced this pull request Apr 18, 2017
test: remove common.PORT from multiple tests
PR-URL: #12451
Ref: #12376
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 18, 2017

Landed in 2e5188d

@jasnell jasnell closed this Apr 18, 2017

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
test: remove common.PORT from multiple tests
PR-URL: #12451
Ref: #12376
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: remove common.PORT from multiple tests
PR-URL: #12451
Ref: #12376
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: remove common.PORT from multiple tests
PR-URL: #12451
Ref: #12376
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.