benchmark: reduce string concatenations #12455

vsemozhetbyt · Apr 17, 2017

Checklist

tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

benchmark

I. Presupposition

String concatenations usually increase syntax noise and add confusion (a reader often has to check if string concatenation or number addition is intended). Moreover, it seems this method is not optimal performance-wise.

II. Cases

This PR aims two cases of string concatenation:

multipart concatenations with variable interpolation ('a' + b + 'c');
type coercion to String ('' + notString). This approach, while idiomatic, is not most declarative.

III. Performance

The added benchmark compares these variants:

'a' + b + 'c' vs ['a', b, 'c'].join('') vs `a${b}c`
String(notString) vs '' + notString vs `${notString}`

Results with Node.js 8.0.0 rc:

es\string-concatenations.js mode="multi-concat"       n=1000:   909,455.5180758832
es\string-concatenations.js mode="multi-join"         n=1000:   290,896.9895943238
es\string-concatenations.js mode="multi-template"     n=1000: 2,620,236.0832711025

es\string-concatenations.js mode="to-string-string"   n=1000: 6,020,179.642160523
es\string-concatenations.js mode="to-string-concat"   n=1000: 1,141,656.7723079734
es\string-concatenations.js mode="to-string-template" n=1000: 5,700,376.794906143

IV. Commits

Reduce string concatenations: replace concatenations with template literals, rewrap,
String.prototype.repeat(), String(). Some replacements do not add indisputable readability gain, but I tried to be consistent.
Add a benchmark for string concatenations vs counterparts.
This commit is added here to avoid PR race condition and merge conflicts. It fixes an URL in _http-benchmarkers.js (removes duplicate hash symbol).
This commit is added here to avoid PR race condition and merge conflicts. It fixes an evident typo in _http-benchmarkers.js: Error() constructor has only one parameter, while callback() has 5 (compare a previous call and callback() signature).

All changed files were minimally tested. CI for linting and new tests concerning benchmarks will be launched.

vsemozhetbyt · Apr 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7434/

mscdex · Apr 17, 2017

mscdex reviewed Apr 17, 2017

View changes

mscdex · Apr 17, 2017

Sign in to view

+        'Uint32Array',
+        'Float32Array',
+        'Float64Array',
+        'Uint8ClampedArray',


Indented too far.

mscdex · Apr 17, 2017

mscdex reviewed Apr 17, 2017

View changes

mscdex · Apr 17, 2017

Sign in to view

-                       'https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md##http-benchmark-requirements ' +
-                       'for further instructions.'));
+    callback(new Error(`Could not locate required http benchmarker. See ${
+                                  requirementsURL} for further instructions.`));


Why the odd indentation here and elsewhere? Shouldn't they line up with the beginning of the string?

I've tried to stress the subordinate state of the next part. I'll try to decrease indentation.

mscdex · Apr 17, 2017

mscdex reviewed Apr 17, 2017

View changes

mscdex · Apr 17, 2017

benchmark/_benchmark_progress.js

-          `| ${fraction(completedRunsForFile, runsPerFile)} runs ` +
-          `| ${fraction(completedConfig, scheduledConfig)} configs]` +
-          `: ${caption} `;
+    return `[${getTime(diff)}|% ${


FWIW I'm not particularly a fan of this style to avoid the extra spacing.

Can you elaborate?

Using ${ followed by a newline to avoid including spaces due to indentation.

vsemozhetbyt · Apr 17, 2017

Some indentation was reduced. New CI: https://ci.nodejs.org/job/node-test-pull-request/7435/

benjamingr · Apr 17, 2017

benjamingr reviewed Apr 17, 2017

View changes

benjamingr · Apr 17, 2017

benchmark/buffers/buffer-bytelength.js

@@ -54,9 +54,3 @@ function main(conf) {
  }
  bench.end(n);
 }
-
-function buildString(str, times) {


It's funny we even had a recursive implementation :D

Yeah, I am even sorry to retire it)

benjamingr · Apr 17, 2017

benjamingr reviewed Apr 17, 2017

View changes

benjamingr · Apr 17, 2017

benchmark/buffers/buffer-write.js

-    '  buff.' + fn + '(i, 0, ' + JSON.stringify(noAssert) + ');',
-    '}'
-  ].join('\n'));
+  var testFunction = new Function('buff', `


benjamingr · Apr 17, 2017

benjamingr reviewed Apr 17, 2017

View changes

benjamingr · Apr 17, 2017

Sign in to view

@@ -44,7 +44,7 @@ Benchmark.prototype._parseArgs = function(argv, configs) {
  for (const arg of argv) {
    const match = arg.match(/^(.+?)=([\s\S]*)$/);
    if (!match || !match[1]) {
-      console.error('bad argument: ' + arg);
+      console.error(`bad argument: ${arg}`);


console.error('bad argument:', arg) ?

I think this would imply we need inspect() for arg (as we do for Error objects), while arg is a simple string.

benjamingr · Apr 17, 2017

benjamingr approved these changes Apr 17, 2017

View changes

jasnell · Apr 17, 2017

jasnell reviewed Apr 17, 2017

View changes

jasnell · Apr 17, 2017

benchmark/buffers/buffer-read.js

@@ -30,14 +30,14 @@ function main(conf) {
  var len = +conf.millions * 1e6;
  var clazz = conf.buf === 'fast' ? Buffer : require('buffer').SlowBuffer;
  var buff = new clazz(8);
-  var fn = 'read' + conf.type;
+  var fn = `read${conf.type}`;


just a reminder that this will make it impossible to run these benchmarks to compare against anything older than 4.0.0. That's not an objection, by any means.

Yes, but there were many other template literals in benchmarks before this edition, including common.js.

At this point I don't think it really matters. I can't see anyone wanting to run the benchmarks for v0.10 or v0.12 anymore, especially since it wouldn't really do any good (it's not as if the V8 team can/will revert to v0.10/v0.12-era V8 code if there is a performance issue in node v4.x+).

Yep, as I said, it's not an objection. Just noting the change. We may want to let folks know just so that they're aware.

I think a lot of benchmarks don't run on v4.x or older anyways...I've seen people on IRC
asking why some benchmark doesn't run and turns out they are using v4.x to run it

vsemozhetbyt added the benchmark label Apr 17, 2017

nodejs-github-bot added assert benchmark buffer crypto fs http module net V8 Engine labels Apr 17, 2017

vsemozhetbyt removed assert buffer crypto fs http module net V8 Engine labels Apr 17, 2017

vsemozhetbyt force-pushed the vsemozhetbyt:bench-templates branch Apr 17, 2017

vsemozhetbyt referenced this pull request Apr 28, 2017
Closed
test: reduce string concatenations #12735
3 of 24 tasks complete

evanlucas referenced this pull request May 1, 2017
Merged
v7.10.0 proposal #12775

evanlucas added a commit that referenced this pull request May 1, 2017

benchmark: add benchmark for string concatenations
PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

ec32e01

evanlucas added a commit that referenced this pull request May 2, 2017

benchmark: add benchmark for string concatenations
PR-URL: #12455 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

7d87edc

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request May 5, 2017

test: reduce string concatenations
Refs: nodejs#12455

009083a

vsemozhetbyt added a commit that referenced this pull request May 5, 2017

test: reduce string concatenations
PR-URL: #12735 Refs: #12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

8b76c3e

anchnk added a commit to anchnk/node that referenced this pull request May 6, 2017

test: reduce string concatenations
PR-URL: nodejs#12735 Refs: nodejs#12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

50d2298

gibfahn added baking-for-lts lts-watch-v6.x labels May 16, 2017

jasnell referenced this pull request May 11, 2017
Closed
8.0.0 Release Proposal #12220

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Jun 23, 2017

test: reduce string concatenations
PR-URL: nodejs#12735 Refs: nodejs#12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

e0d8afa

MylesBorins removed the baking-for-lts label Aug 17, 2018

nodejs/node

Join GitHub today

benchmark: reduce string concatenations #12455

Conversation

vsemozhetbyt commented Apr 17, 2017

Checklist

Affected core subsystem(s)

I. Presupposition

II. Cases

III. Performance

IV. Commits

vsemozhetbyt added the benchmark label Apr 17, 2017

nodejs-github-bot added assert benchmark buffer crypto fs http module net V8 Engine labels Apr 17, 2017

vsemozhetbyt removed assert buffer crypto fs http module net V8 Engine labels Apr 17, 2017

vsemozhetbyt force-pushed the vsemozhetbyt:bench-templates branch Apr 17, 2017

This comment has been minimized.

vsemozhetbyt commented Apr 17, 2017

mscdex reviewed Apr 17, 2017 View changes

This comment has been minimized.

mscdex reviewed Apr 17, 2017 View changes

This comment has been minimized.

mscdex Apr 17, 2017 • edited

This comment has been minimized.

mscdex reviewed Apr 17, 2017 View changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vsemozhetbyt force-pushed the vsemozhetbyt:bench-templates branch Apr 17, 2017

This comment has been minimized.

vsemozhetbyt commented Apr 17, 2017

benjamingr reviewed Apr 17, 2017 View changes

This comment has been minimized.

This comment has been minimized.

benjamingr reviewed Apr 17, 2017 View changes

This comment has been minimized.

benjamingr reviewed Apr 17, 2017 View changes

This comment has been minimized.

This comment has been minimized.

benjamingr approved these changes Apr 17, 2017 View changes

jasnell reviewed Apr 17, 2017 View changes

This comment has been minimized.

This comment has been minimized.

vsemozhetbyt Apr 17, 2017 • edited

This comment has been minimized.

mscdex Apr 17, 2017 • edited

This comment has been minimized.

This comment has been minimized.

vsemozhetbyt referenced this pull request Apr 28, 2017

evanlucas referenced this pull request May 1, 2017

evanlucas added a commit that referenced this pull request May 1, 2017

evanlucas added a commit that referenced this pull request May 2, 2017

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request May 5, 2017

vsemozhetbyt added a commit that referenced this pull request May 5, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 6, 2017

gibfahn added baking-for-lts lts-watch-v6.x labels May 16, 2017

jasnell referenced this pull request May 11, 2017

vsemozhetbyt added a commit to vsemozhetbyt/node that referenced this pull request Jun 23, 2017

MylesBorins added a commit that referenced this pull request Jul 10, 2017

MylesBorins added a commit that referenced this pull request Jul 10, 2017

MylesBorins added a commit that referenced this pull request Jul 11, 2017

MylesBorins removed the baking-for-lts label Aug 17, 2018

mscdex reviewed Apr 17, 2017

View changes

mscdex reviewed Apr 17, 2017

View changes

mscdex Apr 17, 2017 •

edited

mscdex reviewed Apr 17, 2017

View changes

benjamingr reviewed Apr 17, 2017

View changes

benjamingr reviewed Apr 17, 2017

View changes

benjamingr reviewed Apr 17, 2017

View changes

benjamingr approved these changes Apr 17, 2017

View changes

jasnell reviewed Apr 17, 2017

View changes

vsemozhetbyt Apr 17, 2017 •

edited

mscdex Apr 17, 2017 •

edited