Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add missing "http_parser.h" include #12464

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Apr 17, 2017

In 9d52222 the indirect "http_parser.h"
include was removed, which made NODE_STRINGIFY() fail silently for the
http parser version in process.versions.

Ref: #12366
Fixes: #12463

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src/process.versions

CI: https://ci.nodejs.org/job/node-test-commit/9161/

src: add missing "http_parser.h" include
In 9d52222 the indirect "http_parser.h"
include was removed, which made `NODE_STRINGIFY()` fail silently for the
http parser version in `process.versions`.

Ref: #12366
Fixes: #12463
@ghost
ghost approved these changes Apr 17, 2017

@refack refack self-requested a review Apr 17, 2017

@refack
refack approved these changes Apr 17, 2017
@mscdex

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2017

LGTM

@aqrln
aqrln approved these changes Apr 17, 2017
@lpinca
lpinca approved these changes Apr 17, 2017
jasnell added a commit that referenced this pull request Apr 19, 2017
src: add missing "http_parser.h" include
In 9d52222 the indirect "http_parser.h"
include was removed, which made `NODE_STRINGIFY()` fail silently for the
http parser version in `process.versions`.

PR-URL: #12464
Fixes: #12463
Ref: #12366
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

This comment has been minimized.

Copy link
Member

commented Apr 19, 2017

Landed in 6a1275d

@jasnell jasnell closed this Apr 19, 2017

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 18, 2017
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.