Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip tests using ca flags #12485

Closed

Conversation

@danbev
Copy link
Member

commented Apr 18, 2017

Currently when building --without-ssl there is a failure due to a change
made by me in commit 3cf88a4 ("test:
add --use-bundled-ca to tls-cnnic-whitelist") which added a
'--use-bundled-ca' flag to that test. But when building --without-ssl
that flag will be invalid and an error (bad option) will be reported.

This commit filters tests that specify the --use-bundled-ca or
--use-openssl-ca flags so that they are skipped when configured
--without-ssl.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: skip tests using ca flags
Currently when building --without-ssl there is a failure due to a change
made by me in commit 3cf88a4 ("test:
add --use-bundled-ca to tls-cnnic-whitelist") which added a
'--use-bundled-ca' flag to that test. But when building --without-ssl
that flag will be invalid and an error (bad option)  will be reported.

This commit filters tests that specify the --use-bundled-ca or
--use-openssl-ca flags so that they are skipped when configured
--without-ssl.
@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2017

@mscdex mscdex added the openssl label Apr 18, 2017

danbev added a commit to danbev/node that referenced this pull request Apr 20, 2017
test: skip tests using ca flags
Currently when building --without-ssl there is a failure due to a change
made by me in commit 3cf88a4 ("test:
add --use-bundled-ca to tls-cnnic-whitelist") which added a
'--use-bundled-ca' flag to that test. But when building --without-ssl
that flag will be invalid and an error (bad option)  will be reported.

This commit filters tests that specify the --use-bundled-ca or
--use-openssl-ca flags so that they are skipped when configured
--without-ssl.

PR-URL: nodejs#12485
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2017

Landed in f3f9dd7

@danbev danbev closed this Apr 20, 2017

@danbev danbev deleted the danbev:skip-use-bundled-ca-flagged-tests branch Apr 20, 2017

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Should be backported with #11631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.