New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: ICU 59.1 bump #12486

Closed
wants to merge 0 commits into
base: master
from

Conversation

@srl295
Member

srl295 commented Apr 18, 2017

Fixes: #12077

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@srl295 srl295 self-assigned this Apr 18, 2017

@srl295 srl295 added the in progress label Apr 18, 2017

@srl295 srl295 referenced this pull request Apr 18, 2017

Closed

icu4c 59.1 #12461

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 May 8, 2017

Member

OK! v8 now fixed, this should be good. #11753 (comment)

Member

srl295 commented May 8, 2017

OK! v8 now fixed, this should be good. #11753 (comment)

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 May 8, 2017

Member

^ rebased, PTAL all. Will start CI.

⚠️ this may have porting/compiler hurdles ahead (C++11 etc)

Member

srl295 commented May 8, 2017

^ rebased, PTAL all. Will start CI.

⚠️ this may have porting/compiler hurdles ahead (C++11 etc)

@srl295 srl295 requested review from jasnell, MylesBorins and refack May 8, 2017

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 May 8, 2017

Member

fwiw code starting with deps/icu-small/source/common/appendable.cpp in the diffs should all be ICU code under deps.

Member

srl295 commented May 8, 2017

fwiw code starting with deps/icu-small/source/common/appendable.cpp in the diffs should all be ICU code under deps.

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 May 8, 2017

Member

^ CI green

Member

srl295 commented May 8, 2017

^ CI green

@refack

refack approved these changes May 9, 2017

Looks good. Works on my machine.

@gibfahn

gibfahn approved these changes May 9, 2017

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell approved these changes May 9, 2017

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 May 9, 2017

Member

Thanks! FYI @ilovezfs

Member

srl295 commented May 9, 2017

Thanks! FYI @ilovezfs

@mhdawson

Rubber Stamp LGTM.

@mhdawson

This comment has been minimized.

Show comment
Hide comment
@mhdawson

mhdawson May 9, 2017

Member

@srl295 could you paste the link to the CI run into one of the comments for posterity.

Member

mhdawson commented May 9, 2017

@srl295 could you paste the link to the CI run into one of the comments for posterity.

@srl295

This comment has been minimized.

Show comment
Hide comment

@srl295 srl295 closed this May 9, 2017

srl295 added a commit to srl295/node that referenced this pull request May 9, 2017

deps: ICU 59.1 bump
* No feature changes.
* Bug fixes.
* Details: http://site.icu-project.org/download/59

Fixes: nodejs#12077
PR-URL: nodejs#12486
Refs: nodejs#7844
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@srl295 srl295 deleted the srl295:icu4c-59.1 branch May 9, 2017

@srl295 srl295 referenced this pull request May 9, 2017

Closed

Need to get 59.1 data #1

anchnk added a commit to anchnk/node that referenced this pull request May 19, 2017

deps: ICU 59.1 bump
* No feature changes.
* Bug fixes.
* Details: http://site.icu-project.org/download/59

Fixes: nodejs#12077
PR-URL: nodejs#12486
Refs: nodejs#7844
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@jasnell jasnell referenced this pull request May 28, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 20, 2017

Member

I'm assuming this shouldn't land on v6.x as it depends on V8 5.9. LMK if wrong.

Member

gibfahn commented Jun 20, 2017

I'm assuming this shouldn't land on v6.x as it depends on V8 5.9. LMK if wrong.

@srl295

This comment has been minimized.

Show comment
Hide comment
@srl295

srl295 Aug 30, 2017

Member

@gibfahn yes, it would need v8 backported also.

Member

srl295 commented Aug 30, 2017

@gibfahn yes, it would need v8 backported also.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Aug 31, 2017

Member

@srl295 yep, I've confirmed it went into 8.0.0 so we're good there.

Member

gibfahn commented Aug 31, 2017

@srl295 yep, I've confirmed it went into 8.0.0 so we're good there.

srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2018

deps: ICU 59.1 bump
* No feature changes.
* Bug fixes.
* Details: http://site.icu-project.org/download/59

Fixes: nodejs#12077
PR-URL: nodejs#12486
Refs: nodejs#7844
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@srl295 srl295 referenced this pull request Jan 18, 2018

Closed

[v6.x backport] deps: ICU 60.2, 60.1, and 59.1 backports #18240

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment