-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: support promises #12489
Closed
Closed
domain: support promises #12489
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7ce4769
test: introduce `common.crashOnUnhandledRejection`
addaleax 0a07fb9
[squash] use nextTick in crashOnUnhandledRejection
addaleax fbe240a
src: expose `node::AddPromiseHook`
addaleax d0e4911
domain: support promises
addaleax 51a52ee
[squash] address review comments
addaleax f5a9aa5
[squash] one more test + doc `changes:` tag
addaleax 07823ee
[squash] use crashOnUncaughtException in test
addaleax bc9692d
[squash] use AddPromiseHook for domain promise handling
addaleax ddd7c47
[squash] more docs and tests
addaleax a9c2078
[squash] avoid personal pronoun
addaleax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,128 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const domain = require('domain'); | ||
const fs = require('fs'); | ||
const vm = require('vm'); | ||
|
||
common.crashOnUnhandledRejection(); | ||
|
||
{ | ||
const d = domain.create(); | ||
|
||
d.run(common.mustCall(() => { | ||
Promise.resolve().then(common.mustCall(() => { | ||
assert.strictEqual(process.domain, d); | ||
})); | ||
})); | ||
} | ||
|
||
{ | ||
const d = domain.create(); | ||
|
||
d.run(common.mustCall(() => { | ||
Promise.resolve().then(() => {}).then(() => {}).then(common.mustCall(() => { | ||
assert.strictEqual(process.domain, d); | ||
})); | ||
})); | ||
} | ||
|
||
{ | ||
const d = domain.create(); | ||
|
||
d.run(common.mustCall(() => { | ||
vm.runInNewContext(`Promise.resolve().then(common.mustCall(() => { | ||
assert.strictEqual(process.domain, d); | ||
}));`, { common, assert, process, d }); | ||
})); | ||
} | ||
|
||
{ | ||
const d1 = domain.create(); | ||
const d2 = domain.create(); | ||
let p; | ||
d1.run(common.mustCall(() => { | ||
p = Promise.resolve(42); | ||
})); | ||
|
||
d2.run(common.mustCall(() => { | ||
p.then(common.mustCall((v) => { | ||
assert.strictEqual(process.domain, d2); | ||
assert.strictEqual(p.domain, d1); | ||
})); | ||
})); | ||
} | ||
|
||
{ | ||
const d1 = domain.create(); | ||
const d2 = domain.create(); | ||
let p; | ||
d1.run(common.mustCall(() => { | ||
p = Promise.resolve(42); | ||
})); | ||
|
||
d2.run(common.mustCall(() => { | ||
p.then(p.domain.bind(common.mustCall((v) => { | ||
assert.strictEqual(process.domain, d1); | ||
assert.strictEqual(p.domain, d1); | ||
}))); | ||
})); | ||
} | ||
|
||
{ | ||
const d1 = domain.create(); | ||
const d2 = domain.create(); | ||
let p; | ||
d1.run(common.mustCall(() => { | ||
p = Promise.resolve(42); | ||
})); | ||
|
||
d1.run(common.mustCall(() => { | ||
d2.run(common.mustCall(() => { | ||
p.then(common.mustCall((v) => { | ||
assert.strictEqual(process.domain, d2); | ||
assert.strictEqual(p.domain, d1); | ||
})); | ||
})); | ||
})); | ||
} | ||
|
||
{ | ||
const d1 = domain.create(); | ||
const d2 = domain.create(); | ||
let p; | ||
d1.run(common.mustCall(() => { | ||
p = Promise.reject(new Error('foobar')); | ||
})); | ||
|
||
d2.run(common.mustCall(() => { | ||
p.catch(common.mustCall((v) => { | ||
assert.strictEqual(process.domain, d2); | ||
assert.strictEqual(p.domain, d1); | ||
})); | ||
})); | ||
} | ||
|
||
{ | ||
const d = domain.create(); | ||
|
||
d.run(common.mustCall(() => { | ||
Promise.resolve().then(common.mustCall(() => { | ||
setTimeout(common.mustCall(() => { | ||
assert.strictEqual(process.domain, d); | ||
}), 0); | ||
})); | ||
})); | ||
} | ||
|
||
{ | ||
const d = domain.create(); | ||
|
||
d.run(common.mustCall(() => { | ||
Promise.resolve().then(common.mustCall(() => { | ||
fs.readFile(__filename, common.mustCall(() => { | ||
assert.strictEqual(process.domain, d); | ||
})); | ||
})); | ||
})); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation for this should be added to
test/README.md
.