New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pipe some error output if npm fails #12490

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Fishrock123
Member

Fishrock123 commented Apr 18, 2017

This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

Refs: #12480

CI: https://ci.nodejs.org/job/node-test-pull-request/7485/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: pipe some error output if npm fails
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

Refs: #12480
@mscdex

This comment has been minimized.

Show comment
Hide comment
@mscdex

mscdex Apr 18, 2017

Contributor

FWIW I have made a similar change already in #12105.

Contributor

mscdex commented Apr 18, 2017

FWIW I have made a similar change already in #12105.

@BridgeAR

This comment has been minimized.

Show comment
Hide comment
@BridgeAR

BridgeAR Aug 26, 2017

Member

Landed in 99c478e

Member

BridgeAR commented Aug 26, 2017

Landed in 99c478e

@BridgeAR BridgeAR closed this Aug 26, 2017

BridgeAR added a commit that referenced this pull request Aug 26, 2017

test: pipe some error output if npm fails
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

test: pipe some error output if npm fails
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: nodejs/node#12490
Refs: nodejs/node#12480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

oe added a commit to ayojs/ayo that referenced this pull request Aug 30, 2017

test: pipe some error output if npm fails
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: nodejs/node#12490
Refs: nodejs/node#12480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added a commit that referenced this pull request Sep 10, 2017

test: pipe some error output if npm fails
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 10, 2017

Merged

v8.5.0 proposal #15308

MylesBorins added a commit that referenced this pull request Sep 12, 2017

test: pipe some error output if npm fails
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@Fishrock123 Fishrock123 deleted the Fishrock123:more-info-npm-test branch Sep 19, 2017

MylesBorins added a commit that referenced this pull request Sep 20, 2017

test: pipe some error output if npm fails
This test now prints out some child error output if the npm child proc
fails, allowing us to debug easier.

PR-URL: #12490
Refs: #12480
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@MylesBorins MylesBorins referenced this pull request Sep 20, 2017

Merged

v6.11.4 proposal #15506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment