New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove _debugger.js #12495

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@bnoordhuis
Member

bnoordhuis commented Apr 18, 2017

The file no longer works after the removal of the --debug/--debug-brk
switches in commit 47f8f74 ("src: remove support for --debug".)

This commit also removes several tests that still referenced the
old debugger but were either unit-testing its internals or passing
for the wrong reason (like expecting an operation to fail, which
it did because the debugger is gone.)

CI: https://ci.nodejs.org/job/node-test-pull-request/7497/

bnoordhuis added some commits Apr 18, 2017

lib,src,test: update --debug/debug-brk comments
Overlooked in commit 47f8f74 ("src: remove support for --debug") from
earlier this month.
lib: remove _debugger.js
The file no longer works after the removal of the --debug/--debug-brk
switches in commit 47f8f74 ("src: remove support for --debug".)

This commit also removes several tests that still referenced the
old debugger but were either unit-testing its internals or passing
for the wrong reason (like expecting an operation to fail, which
it did because the debugger is gone.)
@jasnell

Removing stuff is goodness.

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 18, 2017

Member

Defensively flagging as semver-major. If it needed be, please remove the flag.

Member

jasnell commented Apr 18, 2017

Defensively flagging as semver-major. If it needed be, please remove the flag.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Apr 18, 2017

Member

There is a request to re-add --debug-brk in master and Node 8: #12364, which would presumably mean that we'd have to keep the --debug-brk bits.

Member

gibfahn commented Apr 18, 2017

There is a request to re-add --debug-brk in master and Node 8: #12364, which would presumably mean that we'd have to keep the --debug-brk bits.

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Apr 18, 2017

Member

What I've removed is all dead code. I was aware of #12364 so I left in the --debug and --debug-brk handling logic in lib/internal/cluster.js.

Whoever is going to pick up that issue should look closely at that file and the NODE_DEBUG_ENABLED logic in particular.

Member

bnoordhuis commented Apr 18, 2017

What I've removed is all dead code. I was aware of #12364 so I left in the --debug and --debug-brk handling logic in lib/internal/cluster.js.

Whoever is going to pick up that issue should look closely at that file and the NODE_DEBUG_ENABLED logic in particular.

@cjihrig

LGTM 👋

@bnoordhuis bnoordhuis closed this Apr 21, 2017

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 21, 2017

lib,src,test: update --debug/debug-brk comments
Overlooked in commit 47f8f74 ("src: remove support for --debug") from
earlier this month.

PR-URL: nodejs#12495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 21, 2017

lib: remove _debugger.js
The file no longer works after the removal of the --debug/--debug-brk
switches in commit 47f8f74 ("src: remove support for --debug".)

This commit also removes several tests that still referenced the
old debugger but were either unit-testing its internals or passing
for the wrong reason (like expecting an operation to fail, which
it did because the debugger is gone.)

PR-URL: nodejs#12495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Apr 21, 2017

Member

For some reason the PR doesn't show up as merged but the relevant changes were landed in ee0620b...90476ac.

Member

bnoordhuis commented Apr 21, 2017

For some reason the PR doesn't show up as merged but the relevant changes were landed in ee0620b...90476ac.

@TimothyGu TimothyGu referenced this pull request Apr 21, 2017

Closed

debugger, errors: migrate to use internal/errors.js #11380

3 of 3 tasks complete

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@bnoordhuis bnoordhuis referenced this pull request Jun 19, 2017

Closed

doc: update debugger.md #13777

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment