Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: unify quotes in an assert.md code example #12505

Closed
wants to merge 1 commit into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Apr 19, 2017

Checklist
Affected core subsystem(s)

doc, assert

@danbev

This comment has been minimized.

@danbev
danbev approved these changes Apr 19, 2017
@lpinca
lpinca approved these changes Apr 19, 2017
@cjihrig
Copy link
Contributor

left a comment

I don't think this needs to sit for 48 hours.

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2017

Landed in 211813c

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:assert.md-quotes branch Apr 19, 2017

vsemozhetbyt added a commit that referenced this pull request Apr 19, 2017
doc: unify quotes in an assert.md code example
PR-URL: #12505
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Fixes #11128 which is semver-major, so marking dont-land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.