Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add coverage for vm's breakOnSigint option #12512

Closed
wants to merge 1 commit into from

Conversation

@cjihrig
Copy link
Contributor

commented Apr 19, 2017

The breakOnSigint option follows different code paths, depending on the number of listeners for SIGINT. This commit updates the existing test to vary the number of SIGINT handlers.

This should get code coverage on lib/vm.js to 100%.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test: add coverage for vm's breakOnSigint option
The breakOnSigint option follows different code paths, depending
on the number of listeners for SIGINT. This commit updates the
existing test to vary the number of SIGINT handlers.

@mscdex mscdex added the vm label Apr 19, 2017

@DavidCai1993

This comment has been minimized.

DavidCai1993 added a commit that referenced this pull request Apr 21, 2017
test: add coverage for vm's breakOnSigint option
The breakOnSigint option follows different code paths, depending
on the number of listeners for SIGINT. This commit updates the
existing test to vary the number of SIGINT handlers.

PR-URL: #12512
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@DavidCai1993

This comment has been minimized.

Copy link
Member

commented Apr 21, 2017

Landed in 4bcbefc

@cjihrig cjihrig deleted the cjihrig:vm branch Apr 21, 2017

@evanlucas

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

This is failing on v7.x-staging. Going to mark as don't land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.