New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: remove obsolete _debug_agent.js #12582

Closed
wants to merge 1 commit into
base: master
from

Conversation

@Trott
Member

Trott commented Apr 22, 2017

With _debugger.js removed, _debug_agent.js appears to be unnecessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

debugger test

debugger: remove obsolete _debug_agent.js
With _debugger.js removed, _debug_agent.js appears to be unnecessary.
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Apr 22, 2017

Member

Assuming I'm not wrong about this being removable, there's probably some related C++ code that can go as well.

Member

Trott commented Apr 22, 2017

Assuming I'm not wrong about this being removable, there's probably some related C++ code that can go as well.

@mscdex mscdex removed the build label Apr 22, 2017

@benjamingr

CI is green, change seems good.

@bnoordhuis

LGTM

there's probably some related C++ code that can go as well.

I was going to look at that next week; there is quite a bit of code that can be deleted. Doesn't need to hold up this PR though.

@addaleax

CI is green 🎉

jasnell added a commit that referenced this pull request Apr 24, 2017

debugger: remove obsolete _debug_agent.js
With _debugger.js removed, _debug_agent.js appears to be unnecessary.

PR-URL: #12582
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell Apr 24, 2017

Member

Landed in 549e81b

Member

jasnell commented Apr 24, 2017

Landed in 549e81b

@jasnell jasnell closed this Apr 24, 2017

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@JacksonTian JacksonTian referenced this pull request Jun 18, 2017

Closed

lib: remove the invalid command line options #13764

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment