Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support unreleased V8 versions #12619

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

commented Apr 24, 2017

Change the RegExp in test-process-versions so that the test can pass
with V8 versions that have no patch number.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, V8

test: support unreleased V8 versions
Change the RegExp in test-process-versions so that the test can pass
with V8 versions that have no patch number.
@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2017

This is required to make the tests pass on the canary branch.

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2017

@mhdawson
Copy link
Member

left a comment

LGTM

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

FreeBSD failure is unrelated.
Landed in d1d9ecf.

@targos targos closed this Apr 26, 2017

@targos targos deleted the targos:process-version-v8 branch Apr 26, 2017

targos added a commit that referenced this pull request Apr 26, 2017
test: support unreleased V8 versions
Change the RegExp in test-process-versions so that the test can pass
with V8 versions that have no patch number.

PR-URL: #12619
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Depends on #12464 which is dont-land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.