Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make tests pass when built without inspector #12622

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

commented Apr 24, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, inspector

test/common.js Outdated
if (!exports.hasCrypto) {
exports.skip('missing ssl support so inspector is disabled');
if (!exports.hasCrypto ||
process.config.variables.v8_enable_inspector === 0) {

This comment has been minimized.

Copy link
@bnoordhuis

bnoordhuis Apr 24, 2017

Member

The !exports.hasCrypto check should be superfluous now.

@targos targos force-pushed the targos:tests-without-inspector branch to 2fb6f1a Apr 24, 2017

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2017

@targos

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

Landed in c8c5a52.

@targos targos closed this Apr 26, 2017

@targos targos deleted the targos:tests-without-inspector branch Apr 26, 2017

targos added a commit that referenced this pull request Apr 26, 2017
test: make tests pass when built without inspector
PR-URL: #12622
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.