Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: dynamic port in dgram tests #12623

Conversation

@sebastianplesciuc
Copy link
Contributor

commented Apr 24, 2017

Removed common.PORT from:

  • test-dgram-close-in-listening
  • test-dgram-close-is-not-callback
  • test-dgram-close
  • test-dgram-exclusive-implicit-bind
  • test-dgram-oob-buffer

This is required in order to eliminate the possibility of port collision in parallel tests.

Refs: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Sebastian Plesciuc
test: dynamic port in dgram tests
Removed common.PORT from test-dgram-close-in-listening,
test-dgram-close-is-not-callback, test-dgram-close,
test-dgram-exclusive-implicit-bind and test-dgram-oob-buffer
in order to eliminate the possibility of port collision.

Refs: #12376
@sebastianplesciuc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

I don't know if this is the most elegant solution. My reasoning was that if we actually send data on UDP we might as well send it to a port we own in that specific test. Or, if we need to send it to a closed port, to call send() in the callback of another socket's close().

Thoughts?

@vsemozhetbyt vsemozhetbyt added the dgram label Apr 24, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2017

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

Landed in d289678, thanks for the PR!

@addaleax addaleax closed this Apr 27, 2017

addaleax added a commit that referenced this pull request Apr 27, 2017
test: dynamic port in dgram tests
Removed common.PORT from test-dgram-close-in-listening,
test-dgram-close-is-not-callback, test-dgram-close,
test-dgram-exclusive-implicit-bind and test-dgram-oob-buffer
in order to eliminate the possibility of port collision.

Refs: #12376
PR-URL: #12623
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

sebastianplesciuc pushed a commit to sebastianplesciuc/node that referenced this pull request Jun 19, 2017
Sebastian Plesciuc
test: dynamic port in dgram tests
Removed common.PORT from test-dgram-close-in-listening,
test-dgram-close-is-not-callback, test-dgram-close,
test-dgram-exclusive-implicit-bind and test-dgram-oob-buffer
in order to eliminate the possibility of port collision.

Refs: nodejs#12376
PR-URL: nodejs#12623
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@sebastianplesciuc

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2017

@gibfahn PR: #13792

Let me know if it's ok. If this shouldn't be backported then I'll close the PR.

gibfahn added a commit that referenced this pull request Jun 20, 2017
test: dynamic port in dgram tests
Removed common.PORT from test-dgram-close-in-listening,
test-dgram-close-is-not-callback, test-dgram-close,
test-dgram-exclusive-implicit-bind and test-dgram-oob-buffer
in order to eliminate the possibility of port collision.

Refs: #12376
PR-URL: #12623
Backport-PR-URL: #13792
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 20, 2017

Let me know if it's ok. If this shouldn't be backported then I'll close the PR.

Looks good to me, thanks for doing it!

MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: dynamic port in dgram tests
Removed common.PORT from test-dgram-close-in-listening,
test-dgram-close-is-not-callback, test-dgram-close,
test-dgram-exclusive-implicit-bind and test-dgram-oob-buffer
in order to eliminate the possibility of port collision.

Refs: #12376
PR-URL: #12623
Backport-PR-URL: #13792
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.