Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test documented napi_get_value_int32 behaviour #12633

Closed
wants to merge 1 commit into from

Conversation

@mhdawson
Copy link
Member

commented Apr 24, 2017

We chose to document this in the docs as there are
different possible behaviours. Adding this test to validate
that all vm implementations do it the same way.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, n-api

test: test documented napi_get_value_int32 behaviour
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.
@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

Arm re-run still had jenkins related issues so trying full CI: https://ci.nodejs.org/job/node-test-pull-request/7692/

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

Arm failures look to be infrastructure issues so not related, rest of CI was green.

@mhdawson

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

landed as 4241577

@mhdawson mhdawson closed this Apr 26, 2017

mhdawson added a commit that referenced this pull request Apr 26, 2017
test: test doc'd napi_get_value_int32 behaviour
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

PR-URL: #12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete

@mhdawson mhdawson deleted the mhdawson:addnumbercov branch Jun 28, 2017

gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 11, 2018
test: test doc'd napi_get_value_int32 behaviour
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

PR-URL: nodejs#12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Mar 31, 2018
test: test doc'd napi_get_value_int32 behaviour
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

PR-URL: nodejs#12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof added a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
test: test doc'd napi_get_value_int32 behaviour
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

PR-URL: nodejs#12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Apr 16, 2018
test: test doc'd napi_get_value_int32 behaviour
We chose to document this in the docs as there are
different possible behaviours.  Adding this test to validate
that all vm implementations do it the same way.

Backport-PR-URL: #19447
PR-URL: #12633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.