Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: modernize and fix code examples in readline.md #12634

Closed
wants to merge 2 commits into from

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Apr 24, 2017

Checklist
Affected core subsystem(s)

doc, readline

  • Improve UX in 2 code examples (add spaces between output and input for better readability).
  • Replace indexOf() by startsWith().
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2017

@lpinca
lpinca approved these changes Apr 25, 2017
doc: improve UX in readline.md code examples
Add spaces between output and input for better readability.

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:readline.md branch to 2a6b727 Apr 25, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

Rebased to test new linter CI: https://ci.nodejs.org/job/node-test-linter/8560/

@mhdawson
Copy link
Member

left a comment

LGTM

vsemozhetbyt added a commit that referenced this pull request Apr 26, 2017
doc: modernize and fix code examples in repl.md
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

Landed in 35d2137

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:readline.md branch Apr 26, 2017

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

Oops. Sorry, typo in the commit message: repl.md should be readline.md. It is late to force push :( I hope this will not cause much confusing.

@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
doc: modernize and fix code examples in repl.md
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
doc: modernize and fix code examples in repl.md
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
doc: modernize and fix code examples in repl.md
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.