Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: dynamic port in parallel regress tests #12639

Conversation

@sebastianplesciuc
Copy link
Contributor

commented Apr 25, 2017

Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.

Refs: #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the net label Apr 25, 2017

test/parallel/test-regress-GH-5727.js Outdated
const address = this.address();
const key = `${address.family.slice(-1)}:${address.address}:${common.PORT}`;
const key = `${address.family.slice(-1)}:${address.address}:${0}`;

This comment has been minimized.

Copy link
@Trott

Trott Apr 25, 2017

Member

${0} can just be 0

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 25, 2017

For test/parallel/test-regress-GH-5051.js, do we actually need to do all this? It creates a request but it never actually runs the request, does it? (Honest question; I'm actually not sure.) If it never tries to connect to a port or anything, then we can just hard-code it to 80 or 8080 or whatever and not do all the net stuff.

@Trott
Copy link
Member

left a comment

I'm pretty sure the 5051 test never actually runs a network request, so we can dispense with net and hardcode any port we like. (I propose 8080.) If you believe differently, by all means, fill me in.

@sebastianplesciuc sebastianplesciuc force-pushed the sebastianplesciuc:common-port-parallel-regress branch Apr 26, 2017

@sebastianplesciuc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

@Trott You're right. I changed it to 8080 and fixed the ${0} issue. Thank you!

@Trott
Trott approved these changes Apr 26, 2017
Copy link
Member

left a comment

LGTM if CI is green. Might want to consider adding a comment where 8080 is being hardcoded explaining that there's no network connection that actually happens; it's a request that gets created but never used. But I'm fine with it as-is too.

@sebastianplesciuc sebastianplesciuc force-pushed the sebastianplesciuc:common-port-parallel-regress branch to 3b6e0bc Apr 26, 2017

Sebastian Plesciuc
test: dynamic port in parallel regress tests
Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.

Refs: #12376
@sebastianplesciuc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

@Trott Added comment :)

@Trott

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 27, 2017

Landed in e927809, thanks for the PR!

@addaleax addaleax closed this Apr 27, 2017

addaleax added a commit that referenced this pull request Apr 27, 2017
test: dynamic port in parallel regress tests
Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.

Refs: #12376
PR-URL: #12639
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@sebastianplesciuc sebastianplesciuc referenced this pull request May 13, 2017
2 of 3 tasks complete
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
test: dynamic port in parallel regress tests
Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.

Refs: #12376
PR-URL: #12639
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: dynamic port in parallel regress tests
Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.

Refs: #12376
PR-URL: #12639
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: dynamic port in parallel regress tests
Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.

Refs: #12376
PR-URL: #12639
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.