Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove obsolete lint comment #12659

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Apr 26, 2017

The eslint-disable comment in test-repl.js appears to have been restored
by accident while restoring other comments. Remove it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test repl

test: remove obsolete lint comment
The eslint-disable comment in test-repl.js appears to have been restored
by accident while restoring other comments. Remove it.

@Trott Trott added repl test labels Apr 26, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2017

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2017

LGTM

@refack
refack approved these changes Apr 26, 2017
@aqrln
aqrln approved these changes Apr 26, 2017
@lpinca
lpinca approved these changes Apr 26, 2017
@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

LGTM

Landed in bda34bd

@addaleax addaleax closed this Apr 26, 2017

addaleax added a commit that referenced this pull request Apr 26, 2017
test: remove obsolete lint comment
The eslint-disable comment in test-repl.js appears to have been restored
by accident while restoring other comments. Remove it.

PR-URL: #12659
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Based on #10155 which is dont-land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.