Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: changes to test/parallel/test-querystring.js #12661

Closed
wants to merge 2 commits into from

Conversation

@lukaszewczak
Copy link
Contributor

commented Apr 26, 2017

Change URIError constructor to regular expression in assert.throws and use block-scope for tests that spans multiple statements

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x ] commit message follows commit guidelines
Affected core subsystem(s)

test

@vsemozhetbyt

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2017

@lpinca
lpinca approved these changes Apr 26, 2017
@lpinca

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

There are a lot of whitespace changes in the diff which can be ignored appending ?w=1 to the URL.
Hope this helps other reviewers who may not know this handy trick.

@lukaszewczak

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

Hi, this error during test/windows-frame build is quite strange for me, and looks like some temporary connectivity issue, not related to my changes...? Could you please run once again this build process.

java.nio.channels.ClosedChannelException
	at org.jenkinsci.remoting.protocol.NetworkLayer.onRecvClosed(NetworkLayer.java:154)
	at org.jenkinsci.remoting.protocol.impl.NIONetworkLayer.ready(NIONetworkLayer.java:179)
	at org.jenkinsci.remoting.protocol.IOHub$OnReady.run(IOHub.java:721)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused: java.io.IOException: Backing channel 'JNLP4-connect connection from 104.130.175.153/104.130.175.153:49164' is disconnected.
@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

@lukaszewczak That’s just the CI infrastructure being a bit problematic sometimes, don’t worry about it. :)

@lukaszewczak

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2017

Uff :-) Thank you @addaleax for quick replay.

@addaleax

This comment has been minimized.

Copy link
Member

commented May 7, 2017

Landed in 42958d1 and fixed up linter errors while landing, thanks for the PR!

@addaleax addaleax closed this May 7, 2017

addaleax added a commit that referenced this pull request May 7, 2017
test: refactor test-querystring
- change URIError constructor to regular expression in assert.throws
- use block-scope for tests that spans multiple statements

PR-URL: #12661
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: refactor test-querystring
- change URIError constructor to regular expression in assert.throws
- use block-scope for tests that spans multiple statements

PR-URL: nodejs#12661
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: refactor test-querystring
- change URIError constructor to regular expression in assert.throws
- use block-scope for tests that spans multiple statements

PR-URL: #12661
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: refactor test-querystring
- change URIError constructor to regular expression in assert.throws
- use block-scope for tests that spans multiple statements

PR-URL: #12661
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.