Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8: fix gcc 7 build errors #12676

Closed
wants to merge 1 commit into from

Conversation

@kasicka
Copy link

commented Apr 26, 2017

Porting #12392 to master
Fixes: #10388

  • make -j4 test (UNIX)
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

While trying to build latest v8.0.0-nightly on Fedora rawhide with gcc 7.0.1 I encountered some errors, so I'm opening this PR against master.

Zuzana Svetlikova
v8: fix gcc 7 build errors
Porting #12392 to master
Fixes: #10388
@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 26, 2017

@mscdex mscdex added build and removed build labels Apr 26, 2017

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 29, 2017

The previous CI 404s (it might be because the CI was reset?), new attempt: https://ci.nodejs.org/job/node-test-commit/9506/

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 29, 2017

The ARM failures might be related, trying again to be sure: https://ci.nodejs.org/job/node-test-commit-arm-fanned/8371/ (edit: green)

@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 29, 2017

Landed in b07e1a8, thanks for the PR!

@addaleax addaleax closed this Apr 29, 2017

addaleax added a commit that referenced this pull request Apr 29, 2017
v8: fix gcc 7 build errors
Porting #12392 to master

Ref: #12392
Fixes: #10388
PR-URL: #12676
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit to targos/node that referenced this pull request May 6, 2017
v8: fix gcc 7 build errors
Porting nodejs#12392 to master

Ref: nodejs#12392
Fixes: nodejs#10388
PR-URL: nodejs#12676
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos added a commit that referenced this pull request May 6, 2017
v8: fix gcc 7 build errors
Porting #12392 to master

Ref: #12392
Fixes: #10388
PR-URL: #12676
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
Zuzana Svetlikova Olivier Martin
v8: fix gcc 7 build errors
Porting nodejs#12392 to master

Ref: nodejs#12392
Fixes: nodejs#10388
PR-URL: nodejs#12676
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

This was backported to v6.x in #13574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.