Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage of buffer #12714

Closed

Conversation

@DavidCai1993
Copy link
Member

commented Apr 28, 2017

Increase coverage of lib/buffer.js.

This should get code coverage on lib/buffer.js to 100%.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott

This comment has been minimized.

Copy link
Member

commented Apr 28, 2017

Hooray! It was at 100% a couple weeks ago. It will be nice to have it back there!

@DavidCai1993

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2017

@mhdawson
Copy link
Member

left a comment

LGTM

DavidCai1993 added a commit that referenced this pull request May 3, 2017
test: increase coverage of buffer
Increase coverage of lib/buffer.js.

PR-URL: #12714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@DavidCai1993

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

Landed in 04796ee.

@DavidCai1993 DavidCai1993 referenced this pull request May 4, 2017
3 of 3 tasks complete
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
test: increase coverage of buffer
Increase coverage of lib/buffer.js.

PR-URL: nodejs#12714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Lands cleanly but fails with this error:

➜  node git:(v6.x-staging) ❯ tools/test.py parallel/test-buffer-bytelength.js
=== release test-buffer-bytelength ===                    
Path: parallel/test-buffer-bytelength
assert.js:81
  throw new assert.AssertionError({
  ^
AssertionError: 0 === -1
    at Object.<anonymous> (/Users/gib/wrk/com/DANGER/node/test/parallel/test-buffer-bytelength.js:15:8)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:389:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:504:3
Command: out/Release/node /Users/gib/wrk/com/DANGER/node/test/parallel/test-buffer-bytelength.js
[00:00|% 100|+   0|-   1]: Done 
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.