Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove common.PORT in test tls ticket cluster #12715

Closed
wants to merge 1 commit into from

Conversation

@ooHmartY
Copy link
Contributor

commented Apr 28, 2017

Updating tests to remove common.PORT per issue #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the tls label Apr 28, 2017

@cjihrig
cjihrig approved these changes May 1, 2017
Copy link
Contributor

left a comment

LGTM if the CI passes

@santigimeno

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented May 7, 2017

Landed in dac9f42, thanks for the PR! :)

@addaleax addaleax closed this May 7, 2017

addaleax added a commit that referenced this pull request May 7, 2017
test: remove common.PORT in test tls ticket cluster
PR-URL: #12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
test: remove common.PORT in test tls ticket cluster
PR-URL: nodejs#12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: remove common.PORT in test tls ticket cluster
PR-URL: #12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: remove common.PORT in test tls ticket cluster
PR-URL: #12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.