New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick bfae9db from upstream v8 #12722

Merged
merged 1 commit into from May 1, 2017

Conversation

Projects
None yet
9 participants
@bnoordhuis
Member

bnoordhuis commented Apr 28, 2017

Original commit message:

Update postmortem metadata generator.

Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.

Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}

Refs: nodejs/llnode#81

@targos

targos approved these changes Apr 28, 2017

@mscdex mscdex added the post-mortem label Apr 28, 2017

@mhdawson

LGTM

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@bnoordhuis bnoordhuis closed this May 1, 2017

@bnoordhuis bnoordhuis deleted the bnoordhuis:cherry-pick-bfae9db branch May 1, 2017

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis
Member

bnoordhuis commented May 1, 2017

@bnoordhuis bnoordhuis merged commit 6ed791c into nodejs:master May 1, 2017

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas May 1, 2017

Member

I'm assuming this shouldn't land on v7.x?

Member

evanlucas commented May 1, 2017

I'm assuming this shouldn't land on v7.x?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis May 1, 2017

Member

I think it could but llnode won't use it. There should be no negative consequences to back-porting.

Member

bnoordhuis commented May 1, 2017

I think it could but llnode won't use it. There should be no negative consequences to back-porting.

@evanlucas

This comment has been minimized.

Show comment
Hide comment
@evanlucas

evanlucas May 1, 2017

Member

Thanks for the confirmation Ben!

Member

evanlucas commented May 1, 2017

Thanks for the confirmation Ben!

bnoordhuis added a commit to bnoordhuis/llnode that referenced this pull request May 2, 2017

src,test: support node.js >= 8
Teach the object property decoder to recognize the layout of objects
in newer versions of V8.

Fixes: nodejs#81
PR-URL: nodejs#82
Refs: https://codereview.chromium.org/2842843004/
Refs: nodejs/node#12722
Reviewed-By: Howard Hellyer <hhellyer@uk.ibm.com>

anchnk added a commit to anchnk/node that referenced this pull request May 6, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos added a commit to targos/node that referenced this pull request May 6, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos added a commit that referenced this pull request May 6, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

targos added a commit to targos/node that referenced this pull request Jun 6, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos added a commit to targos/node that referenced this pull request Jun 7, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

addaleax added a commit to targos/node that referenced this pull request Jun 17, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax added a commit that referenced this pull request Jun 17, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@addaleax addaleax referenced this pull request Jun 17, 2017

Merged

v8.2.0 proposal #13744

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 18, 2017

Member

@bnoordhuis should this land on v6.x?

Member

gibfahn commented Jun 18, 2017

@bnoordhuis should this land on v6.x?

@bnoordhuis

This comment has been minimized.

Show comment
Hide comment
@bnoordhuis

bnoordhuis Jun 19, 2017

Member

No. I've added labels.

Member

bnoordhuis commented Jun 19, 2017

No. I've added labels.

addaleax added a commit that referenced this pull request Jun 21, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax added a commit that referenced this pull request Jun 24, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

rvagg added a commit that referenced this pull request Jun 29, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax added a commit that referenced this pull request Jul 11, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax added a commit that referenced this pull request Jul 18, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos added a commit to targos/node that referenced this pull request Jul 21, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

addaleax added a commit that referenced this pull request Jul 24, 2017

deps: cherry-pick bfae9db from upstream v8
Original commit message:

    Update postmortem metadata generator.

    Add PropertyDetails::AttributesField +
    PropertyDetails::LocationField.

    Review-Url: https://codereview.chromium.org/2842843004
    Cr-Commit-Position: refs/heads/master@{#44889}

PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@addaleax addaleax referenced this pull request Jul 24, 2017

Closed

v8.3.0 proposal #14452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment