New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: remove debug arg handling #12738

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Trott
Member

Trott commented Apr 29, 2017

--debug and --debug-brk are no longer valid flags so remove special
handling for them in the cluster module. Even if they are restored, they
will be aliases for inspect and will not use the legacy debug protocol,
so the special handling will not be needed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

cluster debugger

cluster: remove debug arg handling
--debug and --debug-brk are no longer valid flags so remove special
handling for them in the cluster module. Even if they are restored, they
will be aliases for inspect and will not use the legacy debug protocol,
so the special handling will not be needed.
@Trott

This comment has been minimized.

Show comment
Hide comment

@Trott Trott removed the windows label Apr 29, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 29, 2017

Member

What about line 108?

Member

refack commented Apr 29, 2017

What about line 108?

@Trott

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott May 2, 2017

Member

Landed in dc3bbb4.

@refack: Might not want to touch line 108 until the whole "are we aliasing --debug-brk etc." stuff is worked out. The code in this PR can go whether or not --debug and --debug-brk are aliases for --inspect and --inspect-brk, but the regexp in line 108 may be needed.

Member

Trott commented May 2, 2017

Landed in dc3bbb4.

@refack: Might not want to touch line 108 until the whole "are we aliasing --debug-brk etc." stuff is worked out. The code in this PR can go whether or not --debug and --debug-brk are aliases for --inspect and --inspect-brk, but the regexp in line 108 may be needed.

Trott added a commit to Trott/io.js that referenced this pull request May 2, 2017

cluster: remove debug arg handling
--debug and --debug-brk are no longer valid flags so remove special
handling for them in the cluster module. Even if they are restored, they
will be aliases for inspect and will not use the legacy debug protocol,
so the special handling will not be needed.

PR-URL: nodejs#12738
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@Trott Trott closed this May 2, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 6, 2017

cluster: remove debug arg handling
--debug and --debug-brk are no longer valid flags so remove special
handling for them in the cluster module. Even if they are restored, they
will be aliases for inspect and will not use the legacy debug protocol,
so the special handling will not be needed.

PR-URL: nodejs#12738
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment