Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: turn buffer type-CHECK into exception #12753

Closed

Conversation

@addaleax
Copy link
Member

commented Apr 29, 2017

Turn a CHECK() that could be brought to fail using public APIs
into throwing an error.

Fixes: #12152

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

stream_base

@refack
refack approved these changes Apr 30, 2017

@mscdex mscdex added the stream label Apr 30, 2017

@jasnell
jasnell approved these changes May 1, 2017

@addaleax addaleax added lib / src and removed stream labels May 3, 2017

@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

addaleax added 2 commits Apr 29, 2017
src: turn buffer type-CHECK into exception
Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: #12152

@addaleax addaleax force-pushed the addaleax:fix-type-confusion-cash-12152 branch to a9e1bba May 3, 2017

@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

Had to fix up the test because it previously depended on the type of process.stdout, PTAL

New CI: https://ci.nodejs.org/job/node-test-commit/9603/

@refack

This comment has been minimized.

Copy link
Member

commented May 3, 2017

It's a test, it's run on it's own, who can manipulate process.stdout?
Figured out it's tap...

@refack
refack approved these changes May 3, 2017
@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

Figured out it's tap...

tap? ^^ It’s our test runner that runs it with a temporary file as stdout, yea.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

Landed in 9990be2

@addaleax addaleax closed this May 3, 2017

@addaleax addaleax deleted the addaleax:fix-type-confusion-cash-12152 branch May 3, 2017

addaleax added a commit that referenced this pull request May 3, 2017
src: turn buffer type-CHECK into exception
Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: #12152
PR-URL: #12753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
src: turn buffer type-CHECK into exception
Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: nodejs#12152
PR-URL: nodejs#12753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

@addaleax should this be backported?

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2017

@gibfahn Yes.

gibfahn added a commit that referenced this pull request Jun 18, 2017
src: turn buffer type-CHECK into exception
Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: #12152
PR-URL: #12753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@gibfahn gibfahn added land-on-v6.x and removed lts-watch-v6.x labels Jun 18, 2017

gibfahn added a commit that referenced this pull request Jun 20, 2017
src: turn buffer type-CHECK into exception
Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: #12152
PR-URL: #12753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
src: turn buffer type-CHECK into exception
Turn a `CHECK()` that could be brought to fail using public APIs
into throwing an error.

Fixes: #12152
PR-URL: #12753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.