Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ignore node_trace.*.log #12754

Closed
wants to merge 1 commit into from

Conversation

@watilde
Copy link
Member

commented Apr 30, 2017

Refs: #9304

Checklist
Affected core subsystem(s)

@watilde watilde added the tools label Apr 30, 2017

@ChALkeR
Copy link
Member

left a comment

LGTM.

The commit message should probably have some kind of a description, though, apart from the Refs.

E.g. node_trace.*.log files are generated by NodeTraceWriter or something like that.

tools: ignore node_trace.*.log
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304

@watilde watilde force-pushed the watilde:gitignore-log branch to f4b82ae May 1, 2017

@watilde

This comment has been minimized.

Copy link
Member Author

commented May 1, 2017

Updated the description in the commit message with @ChALkeR 's comment.

@jasnell
jasnell approved these changes May 1, 2017
@watilde

This comment has been minimized.

Copy link
Member Author

commented May 2, 2017

Landed in 678079c

Landed in 595d4ec
(added reviewed-by to the last line quickly...)

@watilde watilde closed this May 2, 2017

@watilde watilde deleted the watilde:gitignore-log branch May 2, 2017

watilde added a commit that referenced this pull request May 2, 2017
tools: ignore node_trace.*.log
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
tools: ignore node_trace.*.log
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: nodejs#9304
PR-URL: nodejs#12754
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
tools: ignore node_trace.*.log
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
tools: ignore node_trace.*.log
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
tools: ignore node_trace.*.log
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.