Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skipIfInspectorDisabled cluster-inspect-brk #12757

Closed

Conversation

@danbev
Copy link
Member

commented Apr 30, 2017

When configured --without-ssl the inspect-brk option will not be
available and the process will exit with a exit value of 9 "Invalid
Argument/Bad option".

This commit adds a skipIfInspectorDisabled check since --without-ssl
implies that no inspector support is build as well.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2017

test/sequential/test-cluster-inspect-brk.js Outdated
@@ -1,5 +1,9 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto) {

This comment has been minimized.

Copy link
@targos

targos Apr 30, 2017

Member

I think it can just be common.skipIfInspectorDisabled()

This comment has been minimized.

Copy link
@refack

refack Apr 30, 2017

Member

IMHO not having SSL is not a reason to skip this test, that's a regression.
What @targos suggested makes more sense, and should be reflected in title and commit message, i.e. test: skip cluster-inspect-brk if inspector is disabled

@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2017

@refack

This comment has been minimized.

Copy link
Member

commented Apr 30, 2017

Is it the same with just --inspect? Isn't that a bigger problem?
IMHO we need to have inspector fallback to HTTP.

Ref: #12758

test/sequential/test-cluster-inspect-brk.js Outdated
@@ -1,5 +1,9 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto) {

This comment has been minimized.

Copy link
@refack

refack Apr 30, 2017

Member

IMHO not having SSL is not a reason to skip this test, that's a regression.
What @targos suggested makes more sense, and should be reflected in title and commit message, i.e. test: skip cluster-inspect-brk if inspector is disabled

test: skipIfInspectorDisabled cluster-inspect-brk
When configured --without-ssl the inspect-brk option will not be
available and the process will exit with a exit value of 9 "Invalid
Argument/Bad option".

This commit adds a skipIfInspectorDisabled check since --without-ssl
implies that no inspector support is build as well.

@danbev danbev force-pushed the danbev:add-hasCrypto-check-cluster-inspect-brk branch to 2cb2411 Apr 30, 2017

@danbev danbev changed the title test: add hasCrypto check to cluster-inspect-brk test: skipIfInspectorDisabled cluster-inspect-brk Apr 30, 2017

@danbev

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2017

@refack
refack approved these changes Apr 30, 2017
Copy link
Member

left a comment

Thanks.

@targos
targos approved these changes Apr 30, 2017
@jasnell
jasnell approved these changes May 1, 2017
danbev added a commit to danbev/node that referenced this pull request May 2, 2017
test: skipIfInspectorDisabled cluster-inspect-brk
When configured --without-ssl the inspect-brk option will not be
available and the process will exit with a exit value of 9 "Invalid
Argument/Bad option".

This commit adds a skipIfInspectorDisabled check since --without-ssl
implies that no inspector support is build as well.

PR-URL: nodejs#12757
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev

This comment has been minimized.

Copy link
Member Author

commented May 2, 2017

Landed in 10ccf56

@danbev danbev closed this May 2, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
test: skipIfInspectorDisabled cluster-inspect-brk
When configured --without-ssl the inspect-brk option will not be
available and the process will exit with a exit value of 9 "Invalid
Argument/Bad option".

This commit adds a skipIfInspectorDisabled check since --without-ssl
implies that no inspector support is build as well.

PR-URL: nodejs#12757
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Should land with #12615

@danbev danbev deleted the danbev:add-hasCrypto-check-cluster-inspect-brk branch Jun 28, 2017

@MylesBorins MylesBorins referenced this pull request Oct 16, 2017
2 of 2 tasks complete
MylesBorins added a commit that referenced this pull request Oct 16, 2017
test: skipIfInspectorDisabled cluster-inspect-brk
When configured --without-ssl the inspect-brk option will not be
available and the process will exit with a exit value of 9 "Invalid
Argument/Bad option".

This commit adds a skipIfInspectorDisabled check since --without-ssl
implies that no inspector support is build as well.

PR-URL: #12757
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Oct 17, 2017
MylesBorins added a commit that referenced this pull request Oct 25, 2017
test: skipIfInspectorDisabled cluster-inspect-brk
When configured --without-ssl the inspect-brk option will not be
available and the process will exit with a exit value of 9 "Invalid
Argument/Bad option".

This commit adds a skipIfInspectorDisabled check since --without-ssl
implies that no inspector support is build as well.

PR-URL: #12757
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins referenced this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.