New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: remove pointless C++ utility methods #12760

Closed
wants to merge 1 commit into
base: master
from

Conversation

@addaleax
Member

addaleax commented Apr 30, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/buffer

CI: https://ci.nodejs.org/job/node-test-commit/9526/ (edit: green)

@ChALkeR

This comment has been minimized.

Show comment
Hide comment
@ChALkeR

ChALkeR Apr 30, 2017

Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7766/

Upd: sorry, @addaleax, I didn't notice the original CI. :-/
Probably because I expected to see CI status below.

Member

ChALkeR commented Apr 30, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7766/

Upd: sorry, @addaleax, I didn't notice the original CI. :-/
Probably because I expected to see CI status below.

@mhdawson

LGTM

@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 2, 2017

Member

One failure in CI does not look related.

Member

jasnell commented May 2, 2017

One failure in CI does not look related.

@jasnell

jasnell approved these changes May 2, 2017

jasnell added a commit that referenced this pull request May 2, 2017

buffer: remove pointless C++ utility methods
PR-URL: #12760
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

This comment has been minimized.

Show comment
Hide comment
@jasnell

jasnell May 2, 2017

Member

Landed in 9d723e8

Member

jasnell commented May 2, 2017

Landed in 9d723e8

@jasnell jasnell closed this May 2, 2017

@addaleax addaleax deleted the addaleax:buffer-extra-templates branch May 2, 2017

anchnk added a commit to anchnk/node that referenced this pull request May 6, 2017

buffer: remove pointless C++ utility methods
PR-URL: nodejs#12760
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete
@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Jun 18, 2017

Member

Doesn't land cleanly, willing to backport to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Member

gibfahn commented Jun 18, 2017

Doesn't land cleanly, willing to backport to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment