Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase readline coverage #12761

Closed
wants to merge 2 commits into from

Conversation

@addaleax
Copy link
Member

commented Apr 30, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, readine

input: input
});

rl.on('line', () => assert.fail('must not be called before newline'));

This comment has been minimized.

Copy link
@mscdex

mscdex Apr 30, 2017

Contributor

common.mustNotCall()?

This comment has been minimized.

Copy link
@addaleax

addaleax Apr 30, 2017

Author Member

Sure, why not. updated

@Trott
Trott approved these changes Apr 30, 2017
Copy link
Member

left a comment

LGTM if Ci is green

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2017

@mscdex

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2017

LGTM

@ChALkeR
Copy link
Member

left a comment

LGTM.

Minor nit: do we have exact numbers for the coverage?
If yes, it would make sense to include those (before/after) to the commit message on the second line.

@addaleax

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2017

@ChALkeR In theory, I could run make coverage locally before/after this change, and for readline there’s a good chance it would give results comparable to the ones generated by CI.

Running make coverage is still a bit of a hustle, though, and also I had these changes lying around for a few days so I don’t actually remember which uncovered lines these cover… Originally I wanted to add more test cases here, but since that didn’t happen, I thought I might as well just open a PR now.

@mhdawson
Copy link
Member

left a comment

LGTM

@lpinca
lpinca approved these changes May 2, 2017
@jasnell
jasnell approved these changes May 2, 2017
@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

Landed in b2ab41e

@addaleax addaleax closed this May 3, 2017

addaleax added a commit that referenced this pull request May 3, 2017
test: increase readline coverage
PR-URL: #12761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@addaleax addaleax deleted the addaleax:readline-tests branch May 3, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
test: increase readline coverage
PR-URL: nodejs#12761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
test: increase readline coverage
PR-URL: #12761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn added a commit that referenced this pull request Jun 20, 2017
test: increase readline coverage
PR-URL: #12761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
test: increase readline coverage
PR-URL: #12761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.