Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing option to node PrintHelp #12763

Closed
wants to merge 1 commit into from

Conversation

@KryDos
Copy link
Contributor

commented Apr 30, 2017

Hi,
the --pending-deprecation option was missed from PrintHelp output of node. The option exists in doc files and of course it is handled by node itself.

P.S.
excuse me, I don't really know what core subsystem it is, so I skip it below.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
@addaleax

This comment has been minimized.

Copy link
Member

commented Apr 30, 2017

Could you update the commit message to something like node: add missing option to --help output? Otherwise this looks good, thanks. :)

@addaleax addaleax added the cli label Apr 30, 2017

@KryDos KryDos force-pushed the KryDos:node-print-help-fix branch Apr 30, 2017

@KryDos

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2017

@addaleax sure, thank you for the help ;)

@KryDos KryDos force-pushed the KryDos:node-print-help-fix branch to 43545c3 Apr 30, 2017

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2017

Does this need to be added to doc/node.1 too?

@KryDos

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2017

@cjihrig it is already there :)

output of the --help option is the only place I found where --pending-deprecation was missing.

@cjihrig
Copy link
Contributor

left a comment

Thanks for double checking. LGTM

@jasnell
jasnell approved these changes May 1, 2017
Copy link
Member

left a comment

Whoops! Thank you!

@mhdawson
Copy link
Member

left a comment

LGTM

@mhdawson

This comment has been minimized.

Copy link
Member

commented May 1, 2017

@KryDos

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2017

CI failed :( but seems unrelated.

@addaleax

This comment has been minimized.

Copy link
Member

commented May 3, 2017

Landed in 896be83

@addaleax addaleax closed this May 3, 2017

addaleax added a commit that referenced this pull request May 3, 2017
node: add missing option to --help output
PR-URL: #12763
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

@KryDos KryDos deleted the KryDos:node-print-help-fix branch May 3, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
node: add missing option to --help output
PR-URL: nodejs#12763
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.