New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcbuild.bat: adding option static enabling the option --enable-static #12764

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@TonyRice
Contributor

TonyRice commented Apr 30, 2017

This simply adds a new (static) option within vcbuild.bat that allows you to easily add the --enable-static option to the visual studio build.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax
Member

addaleax commented Apr 30, 2017

@refack

refack approved these changes Apr 30, 2017

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 30, 2017

Member

@TonyRice I edited the first comment. Removed a space so the checklist will be formatted correctly.

Member

refack commented Apr 30, 2017

@TonyRice I edited the first comment. Removed a space so the checklist will be formatted correctly.

@gibfahn

This comment has been minimized.

Show comment
Hide comment
@gibfahn

gibfahn Apr 30, 2017

Member

Please could you format your commit message according to the Contributing Guidelines?

Maybe something like this?

build: add static option to vcbuild.bat

Passes --enable-static to ./configure.

If you don't have time it can be rewritten by whoever lands this, but if you are going to help out more on the project (as I hope you do), then it saves work if you produce better commit messages.

Member

gibfahn commented Apr 30, 2017

Please could you format your commit message according to the Contributing Guidelines?

Maybe something like this?

build: add static option to vcbuild.bat

Passes --enable-static to ./configure.

If you don't have time it can be rewritten by whoever lands this, but if you are going to help out more on the project (as I hope you do), then it saves work if you produce better commit messages.

@gibfahn

LGTM I guess, though having to duplicate every configure option because we're running it inside vcbuild.bat seems pretty backwards.

@refack

This comment has been minimized.

Show comment
Hide comment
@refack

refack Apr 30, 2017

Member

@gibfahn I agree #12425 (we should all move to ninja)

Member

refack commented Apr 30, 2017

@gibfahn I agree #12425 (we should all move to ninja)

@addaleax

This comment has been minimized.

Show comment
Hide comment
@addaleax

addaleax May 3, 2017

Member

Landed in e488857 with @gibfahn’s suggested commit message, thanks for the PR!

Member

addaleax commented May 3, 2017

Landed in e488857 with @gibfahn’s suggested commit message, thanks for the PR!

@addaleax addaleax closed this May 3, 2017

addaleax added a commit that referenced this pull request May 3, 2017

build: add static option to vcbuild.bat
Passes --enable-static to ./configure.

PR-URL: #12764
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

anchnk added a commit to anchnk/node that referenced this pull request May 6, 2017

build: add static option to vcbuild.bat
Passes --enable-static to ./configure.

PR-URL: nodejs#12764
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@jasnell jasnell referenced this pull request May 11, 2017

Closed

8.0.0 Release Proposal #12220

@gibfahn gibfahn referenced this pull request Jun 15, 2017

Closed

Auditing for 6.11.1 #230

2 of 3 tasks complete

gibfahn added a commit that referenced this pull request Jun 18, 2017

build: add static option to vcbuild.bat
Passes --enable-static to ./configure.

PR-URL: #12764
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

gibfahn added a commit that referenced this pull request Jun 20, 2017

build: add static option to vcbuild.bat
Passes --enable-static to ./configure.

PR-URL: #12764
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins added a commit that referenced this pull request Jul 11, 2017

build: add static option to vcbuild.bat
Passes --enable-static to ./configure.

PR-URL: #12764
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

@MylesBorins MylesBorins referenced this pull request Jul 18, 2017

Merged

v6.11.2 proposal #14356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment