Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove unnecessary parameter #12767

Closed
wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

commented Apr 30, 2017

Delete invalid parameter.

Fixes: #8153

Patch taken straight from the issue, I’ve only edited the title.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

streams

stream: remove unnecessary parameter
Delete invalid parameter.

Fixes: #8153
@lpinca
lpinca approved these changes Apr 30, 2017
@DavidCai1993

This comment has been minimized.

@mscdex

This comment has been minimized.

Copy link
Contributor

commented May 1, 2017

LGTM

@jasnell
jasnell approved these changes May 1, 2017
@addaleax

This comment has been minimized.

Copy link
Member Author

commented May 3, 2017

Landed in d6a6bcd

@addaleax addaleax closed this May 3, 2017

@addaleax addaleax deleted the addaleax:streams-extra-param branch May 3, 2017

addaleax added a commit that referenced this pull request May 3, 2017
stream: remove unnecessary parameter
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
Leo Olivier Martin
stream: remove unnecessary parameter
Delete invalid parameter.

Fixes: nodejs#8153
PR-URL: nodejs#12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
gibfahn added a commit that referenced this pull request Jun 18, 2017
stream: remove unnecessary parameter
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn

This comment has been minimized.

Copy link
Member

commented Jun 18, 2017

Landed on 6.x, LMK if that was a mistake.

gibfahn added a commit that referenced this pull request Jun 20, 2017
stream: remove unnecessary parameter
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins added a commit that referenced this pull request Jul 11, 2017
stream: remove unnecessary parameter
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins referenced this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.