Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable test-debugger-pid #12770

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Apr 30, 2017

Now that node debug is an alias for node inspect, it's possible that
node-debug-pid can run reliably. Modify for current behavior and move
from disabled to parallel.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test debugger inspector

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2017

Labeled as in progress pending CI results as I'm not able to run on Windows etc. locally.

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2017

Hmmm...Windows fails. A few options:

  • skip the test on Windows
  • bifurcated logic to handle Windows behavior
  • remove the test entirely as it's mostly testing the behavior of the node-inspect dependency anyway and not Node.js core itself

Thoughts? /cc @jkrems

@Trott Trott force-pushed the Trott:debugger-test branch May 1, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 1, 2017

Added code to skip parts of the test on Windows.

CI: https://ci.nodejs.org/job/node-test-pull-request/7767/

Because I hope/expect this to pass CI, I'm going to remove the in progress label too...

@jkrems
jkrems approved these changes May 1, 2017
Copy link
Contributor

left a comment

I think in the future we should investigate adding make test-node-inspect to our general CI runs. Until then having some smoke tests like this one as part of node's own test suite is definitely valuable.

@cjihrig
cjihrig approved these changes May 1, 2017
@jasnell
jasnell approved these changes May 1, 2017
@addaleax

This comment has been minimized.

Copy link
Member

commented May 3, 2017

Linter failure:

Running JS linter...
./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.md \
  benchmark doc lib test tools

/home/xxxx/src/node/master/test/parallel/test-debugger-pid.js
  13:7  error  Expected a function declaration  func-style

✖ 1 problem (1 error, 0 warnings)
test: enable test-debugger-pid
Now that `node debug` is an alias for `node inspect`, it's possible that
`node-debug-pid` can run reliably. Modify for current behavior and move
from `disabled` to `parallel`.

@Trott Trott force-pushed the Trott:debugger-test branch to a5f99ae May 4, 2017

@Trott

This comment has been minimized.

Copy link
Member Author

commented May 4, 2017

Rebased and adjusted to conform with new lint rule.

New CI: https://ci.nodejs.org/job/node-test-pull-request/7842/

@refack
refack approved these changes May 4, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 4, 2017
test: enable test-debugger-pid
Now that `node debug` is an alias for `node inspect`, it's possible that
`node-debug-pid` can run reliably. Modify for current behavior and move
from `disabled` to `parallel`.

PR-URL: nodejs#12770
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member Author

commented May 4, 2017

Landed in 4677766

@Trott Trott closed this May 4, 2017

anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
test: enable test-debugger-pid
Now that `node debug` is an alias for `node inspect`, it's possible that
`node-debug-pid` can run reliably. Modify for current behavior and move
from `disabled` to `parallel`.

PR-URL: nodejs#12770
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell referenced this pull request May 11, 2017
@gibfahn gibfahn referenced this pull request Jun 15, 2017
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.